mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 14:52:41 +01:00
Use "resolve()", not "execute()", for PhutilExecPassthru callsites in Phabricator
Summary: Ref T13660. Clean up callsites to "PhutilExecPassthru->execute()" to prepare to deprecate it. Test Plan: - Grepped for "PhutilExecPassthru" and looked for callsites. - Ran `GIT_SSH=.../ssh-connect git ls-remote origin` to execute the "ssh-connect" code. - The two passthru future methods have no callers and could possibly be removed, but I'm just letting sleeping dogs lie for now. Reviewers: cspeckmim Reviewed By: cspeckmim Maniphest Tasks: T13660 Differential Revision: https://secure.phabricator.com/D21703
This commit is contained in:
parent
2f1acf8b10
commit
af6cc0c934
2 changed files with 3 additions and 3 deletions
|
@ -154,6 +154,6 @@ $pattern = implode(' ', $pattern);
|
||||||
array_unshift($arguments, $pattern);
|
array_unshift($arguments, $pattern);
|
||||||
|
|
||||||
$err = newv('PhutilExecPassthru', $arguments)
|
$err = newv('PhutilExecPassthru', $arguments)
|
||||||
->execute();
|
->resolve();
|
||||||
|
|
||||||
exit($err);
|
exit($err);
|
||||||
|
|
|
@ -499,7 +499,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
|
||||||
|
|
||||||
public function passthruRemoteCommand($pattern /* , $arg, ... */) {
|
public function passthruRemoteCommand($pattern /* , $arg, ... */) {
|
||||||
$args = func_get_args();
|
$args = func_get_args();
|
||||||
return $this->newRemoteCommandPassthru($args)->execute();
|
return $this->newRemoteCommandPassthru($args)->resolve();
|
||||||
}
|
}
|
||||||
|
|
||||||
private function newRemoteCommandFuture(array $argv) {
|
private function newRemoteCommandFuture(array $argv) {
|
||||||
|
@ -540,7 +540,7 @@ final class PhabricatorRepository extends PhabricatorRepositoryDAO
|
||||||
|
|
||||||
public function passthruLocalCommand($pattern /* , $arg, ... */) {
|
public function passthruLocalCommand($pattern /* , $arg, ... */) {
|
||||||
$args = func_get_args();
|
$args = func_get_args();
|
||||||
return $this->newLocalCommandPassthru($args)->execute();
|
return $this->newLocalCommandPassthru($args)->resolve();
|
||||||
}
|
}
|
||||||
|
|
||||||
private function newLocalCommandFuture(array $argv) {
|
private function newLocalCommandFuture(array $argv) {
|
||||||
|
|
Loading…
Reference in a new issue