revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-09 05:18:29 +01:00
Code Issues Releases Wiki Activity

Allow draft revisions to be commandeered

Browse source 
Summary:
See PHI457. There's no real reason not to allow this, it just wasn't clear if it was useful. See D18626.

An install had a user `arc diff` and then sprint out the door to take a very long vacation before the builds finished. One failed, so the revision is stuck as a draft forever. This seems like a reasonable motivation for allowing "Commandeer".

Test Plan: Successfully commandeered a draft.

Differential Revision: https://secure.phabricator.com/D19228
This commit is contained in:
epriestley 2018-03-14 13:56:10 -07:00
parent cd7ba6cd7b
commit af8269d2fb
1 changed files with 0 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/applications/differential/xaction/DifferentialRevisionCommandeerTransaction.php
View file

@ -66,11 +66,6 @@ final class DifferentialRevisionCommandeerTransaction
'been closed. You can only commandeer open revisions.')); 'been closed. You can only commandeer open revisions.'));
} }
if ($object->isDraft()) {
throw new Exception(
pht('You can not commandeer a draft revision.'));
}
if ($this->isViewerRevisionAuthor($object, $viewer)) { if ($this->isViewerRevisionAuthor($object, $viewer)) {
throw new Exception( throw new Exception(
pht( pht(