mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-22 06:42:42 +01:00
Remove unused methods in PhabricatorEditorExtension
Summary: The methods `newRequiredTransasctionError()` [sic!] and `newInvalidTransactionError()` are not called anywhere in the codebase. Both are `final protected`, thus remove them. Incidentally, speedup Diviner generation by at least 0.000000000000000000000001 milliseconds. Test Plan: Grep the code. Reviewers: O1 Blessed Committers, valerio.bozzolan Reviewed By: O1 Blessed Committers, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Differential Revision: https://we.phorge.it/D25643
This commit is contained in:
parent
9a44a81e79
commit
b0bba4d142
1 changed files with 0 additions and 14 deletions
|
@ -66,18 +66,4 @@ abstract class PhabricatorEditorExtension
|
|||
$xaction);
|
||||
}
|
||||
|
||||
final protected function newRequiredTransasctionError(
|
||||
PhabricatorApplicationTransaction $xaction,
|
||||
$message) {
|
||||
return $this->newError($xaction, pht('Required'), $message)
|
||||
->setIsMissingFieldError(true);
|
||||
}
|
||||
|
||||
final protected function newInvalidTransactionError(
|
||||
PhabricatorApplicationTransaction $xaction,
|
||||
$message) {
|
||||
return $this->newTransactionError($xaction, pht('Invalid'), $message);
|
||||
}
|
||||
|
||||
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue