revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-02-02 01:48:23 +01:00
Code Issues Releases Wiki Activity

Link to a specific Phabricator version from stack trace

Browse source 
Summary: Line numbers and file paths may be different in current version.

Test Plan: Disabled editor, issued exception, clicked on the link.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D2886
This commit is contained in:
vrana 2012-06-28 16:08:06 -07:00
parent 46008ce3b3
commit b10428fe60
1 changed files with 6 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
View file

@ -630,6 +630,11 @@ class AphrontDefaultApplicationConfiguration
$libraries = PhutilBootloader::getInstance()->getAllLibraries(); $libraries = PhutilBootloader::getInstance()->getAllLibraries();
$version = PhabricatorEnv::getEnvConfig('phabricator.version');
if (preg_match('/[^a-f0-9]/i', $version)) {
$version = '';
}
// TODO: Make this configurable? // TODO: Make this configurable?
$path = 'https://secure.phabricator.com/diffusion/%s/browse/master/src/'; $path = 'https://secure.phabricator.com/diffusion/%s/browse/master/src/';
@ -676,6 +681,7 @@ class AphrontDefaultApplicationConfiguration
if (empty($attrs['href'])) { if (empty($attrs['href'])) {
$attrs['href'] = sprintf($path, $callsigns[$lib]). $attrs['href'] = sprintf($path, $callsigns[$lib]).
str_replace(DIRECTORY_SEPARATOR, '/', $relative). str_replace(DIRECTORY_SEPARATOR, '/', $relative).
($version && $lib == 'phabricator' ? ';'.$version : '').
'$'.$part['line']; '$'.$part['line'];
$attrs['target'] = '_blank'; $attrs['target'] = '_blank';
} }