Force date/time preferences to valid values

Summary:
Fixes T8601. To reproduce the problem:

  - Set your time preference to `""` (the empty string). This isn't possible from the modern UI, but can be done with "Right Click > Inspect Element", or users may have carried it forward from an older setting (this is the case with me and @hach-que on this install).
  - Load Calendar with some events.
  - This parses an epoch, which sets `valueTime` to `""` (since there are no format characters in the preference) and then `getEpoch()` fails because `strlen($time)` is 0.
  - Since `getEpoch()` failed, `getDateTime()` also fails.

To fix this:

  - Only permit the date and time preferences to have valid values.

Test Plan:
  - Loaded page before patch, saw fatal.
  - Applied patch.
  - No more fatal.
  - Viewed tooltips, dates/times, dates/times in other apps.
  - Changed my preferences, saw them respected.

Reviewers: lpriestley

Reviewed By: lpriestley

Subscribers: epriestley, hach-que

Maniphest Tasks: T8601

Differential Revision: https://secure.phabricator.com/D13346

src/__phutil_library_map__.php

@@ -3290,7 +3290,6 @@ phutil_register_library_map(array(
     'phabricator_format_local_time' => 'view/viewutils.php',
     'phabricator_relative_date' => 'view/viewutils.php',
     'phabricator_time' => 'view/viewutils.php',
-    'phabricator_time_format' => 'view/viewutils.php',
     'phid_get_subtype' => 'applications/phid/utils.php',
     'phid_get_type' => 'applications/phid/utils.php',
     'phid_group_by_type' => 'applications/phid/utils.php',

src/applications/people/storage/PhabricatorUser.php

@@ -738,6 +738,41 @@ final class PhabricatorUser
     return new DateTimeZone($this->getTimezoneIdentifier());
   }
 
+  public function getPreference($key) {
+    $preferences = $this->loadPreferences();
+
+    // TODO: After T4103 and T7707 this should eventually be pushed down the
+    // stack into modular preference definitions and role profiles. This is
+    // just fixing T8601 and mildly anticipating those changes.
+    $value = $preferences->getPreference($key);
+
+    $allowed_values = null;
+    switch ($key) {
+      case PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT:
+        $allowed_values = array(
+          'g:i A',
+          'H:i',
+        );
+        break;
+      case PhabricatorUserPreferences::PREFERENCE_DATE_FORMAT:
+        $allowed_values = array(
+          'Y-m-d',
+          'n/j/Y',
+          'd-m-Y',
+        );
+        break;
+    }
+
+    if ($allowed_values !== null) {
+      $allowed_values = array_fuse($allowed_values);
+      if (empty($allowed_values[$value])) {
+        $value = head($allowed_values);
+      }
+    }
+
+    return $value;
+  }
+
   public function __toString() {
     return $this->getUsername();
   }

src/view/form/control/AphrontFormDateControl.php

@@ -137,19 +137,13 @@ final class AphrontFormDateControl extends AphrontFormControl {
   }
 
   private function getTimeFormat() {
-    $viewer = $this->getUser();
+    return $this->getUser()
-    $preferences = $viewer->loadPreferences();
+      ->getPreference(PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT);
-    $pref_time_format = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
-
-    return $preferences->getPreference($pref_time_format, 'g:i A');
   }
 
   private function getDateFormat() {
-    $viewer = $this->getUser();
+    return $this->getUser()
-    $preferences = $viewer->loadPreferences();
+      ->getPreference(PhabricatorUserPreferences::PREFERENCE_DATE_FORMAT);
-    $pref_date_format = PhabricatorUserPreferences::PREFERENCE_DATE_FORMAT;
-
-    return $preferences->getPreference($pref_date_format, 'Y-m-d');
   }
 
   private function getTimeInputValue() {

src/view/form/control/AphrontFormDateControlValue.php

@@ -10,7 +10,6 @@ final class AphrontFormDateControlValue extends Phobject {
   private $zone;
   private $optional;
 
-
   public function getValueDate() {
     return $this->valueDate;
   }
@@ -56,6 +55,10 @@ final class AphrontFormDateControlValue extends Phobject {
     return $this->optional;
   }
 
+  public function getViewer() {
+    return $this->viewer;
+  }
+
   public static function newFromParts(
     PhabricatorUser $viewer,
     $year,
@@ -71,8 +74,7 @@ final class AphrontFormDateControlValue extends Phobject {
         $year,
         $month,
         $day,
-        coalesce($time, '12:00 AM'),
+        coalesce($time, '12:00 AM'));
-        $value);
     $value->valueEnabled = $enabled;
 
     return $value;
@@ -85,8 +87,7 @@ final class AphrontFormDateControlValue extends Phobject {
     list($value->valueDate, $value->valueTime) =
       $value->getFormattedDateFromDate(
         $request->getStr($key.'_d'),
-        $request->getStr($key.'_t'),
+        $request->getStr($key.'_t'));
-        $value);
 
     $value->valueEnabled = $request->getStr($key.'_e');
     return $value;
@@ -108,8 +109,7 @@ final class AphrontFormDateControlValue extends Phobject {
         $year,
         $month,
         $day,
-        $time,
+        $time);
-        $value);
 
     return $value;
   }
@@ -123,8 +123,7 @@ final class AphrontFormDateControlValue extends Phobject {
     list($value->valueDate, $value->valueTime) =
       $value->getFormattedDateFromDate(
         idx($dictionary, 'd'),
-        idx($dictionary, 't'),
+        idx($dictionary, 't'));
-        $value);
 
     $value->valueEnabled = idx($dictionary, 'e');
 
@@ -205,29 +204,25 @@ final class AphrontFormDateControlValue extends Phobject {
   }
 
   private function getTimeFormat() {
-    $preferences = $this->viewer->loadPreferences();
+    return $this->getViewer()
-    $pref_time_format = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
+      ->getPreference(PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT);
-
-    return $preferences->getPreference($pref_time_format, 'g:i A');
   }
 
   private function getDateFormat() {
-    $preferences = $this->viewer->loadPreferences();
+    return $this->getViewer()
-    $pref_date_format = PhabricatorUserPreferences::PREFERENCE_DATE_FORMAT;
+      ->getPreference(PhabricatorUserPreferences::PREFERENCE_DATE_FORMAT);
-
-    return $preferences->getPreference($pref_date_format, 'Y-m-d');
   }
 
-  private function getFormattedDateFromDate($date, $time, $value) {
+  private function getFormattedDateFromDate($date, $time) {
     $original_input = $date;
-    $zone = $value->getTimezone();
+    $zone = $this->getTimezone();
-    $separator = $value->getFormatSeparator();
+    $separator = $this->getFormatSeparator();
     $parts = preg_split('@[,./:-]@', $date);
     $date = implode($separator, $parts);
     $date = id(new DateTime($date, $zone));
 
     if ($date) {
-      $date = $date->format($value->getDateFormat());
+      $date = $date->format($this->getDateFormat());
     } else {
       $date = $original_input;
     }
@@ -235,8 +230,8 @@ final class AphrontFormDateControlValue extends Phobject {
     $date = id(new DateTime("{$date} {$time}", $zone));
 
     return array(
-      $date->format($value->getDateFormat()),
+      $date->format($this->getDateFormat()),
-      $date->format($value->getTimeFormat()),
+      $date->format($this->getTimeFormat()),
     );
   }
 
@@ -244,14 +239,14 @@ final class AphrontFormDateControlValue extends Phobject {
     $year,
     $month,
     $day,
-    $time,
+    $time) {
-    $value) {
+
-    $zone = $value->getTimezone();
+    $zone = $this->getTimezone();
     $date_time = id(new DateTime("{$year}-{$month}-{$day} {$time}", $zone));
 
     return array(
-      $date_time->format($value->getDateFormat()),
+      $date_time->format($this->getDateFormat()),
-      $date_time->format($value->getTimeFormat()),
+      $date_time->format($this->getTimeFormat()),
     );
   }
 

src/view/phui/calendar/PHUICalendarListView.php

@@ -141,11 +141,8 @@ final class PHUICalendarListView extends AphrontTagView {
   }
 
   private function getEventTooltip(AphrontCalendarEventView $event) {
-    $viewer = $this->getUser();
+    $time_pref = $this->getUser()
-    $preferences = $viewer->loadPreferences();
+      ->getPreference(PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT);
-    $time_pref = $preferences->getPreference(
-      PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT,
-      'g:i A');
 
     Javelin::initBehavior('phabricator-tooltips');
 

src/view/viewutils.php

@@ -31,32 +31,21 @@ function phabricator_relative_date($epoch, $user, $on = false) {
 }
 
 function phabricator_time($epoch, $user) {
+  $time_key = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
   return phabricator_format_local_time(
     $epoch,
     $user,
-    phabricator_time_format($user));
+    $user->getPreference($time_key));
 }
 
 function phabricator_datetime($epoch, $user) {
+  $time_key = PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT;
   return phabricator_format_local_time(
     $epoch,
     $user,
     pht('%s, %s',
       phutil_date_format($epoch),
-      phabricator_time_format($user)));
+      $user->getPreference($time_key)));
-}
-
-function phabricator_time_format($user) {
-  $prefs = $user->loadPreferences();
-
-  $pref = $prefs->getPreference(
-    PhabricatorUserPreferences::PREFERENCE_TIME_FORMAT);
-
-  if (strlen($pref)) {
-    return $pref;
-  }
-
-  return pht('g:i A');
 }
 
 /**