Make App Pinning use Stackable list

Summary: This makes setStackble play well in ObjectBox, also tweaks dragging in a stackable box (pinning)

Test Plan: Drag in App Settings, Drag in Maniphest, Workboards

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9413

resources/celerity/map.php

@@ -7,7 +7,7 @@
 return array(
   'names' =>
   array(
-    'core.pkg.css' => 'd9c53a92',
+    'core.pkg.css' => '73e14ee6',
     'core.pkg.js' => '9c9c8442',
     'darkconsole.pkg.js' => 'ca8671ce',
     'differential.pkg.css' => '4a93db37',
@@ -135,7 +135,7 @@ return array(
     'rsrc/css/phui/phui-info-panel.css' => '27ea50a1',
     'rsrc/css/phui/phui-list.css' => '43ed2d93',
     'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec',
-    'rsrc/css/phui/phui-object-item-list-view.css' => '5dfa7e4f',
+    'rsrc/css/phui/phui-object-item-list-view.css' => '31d6da4e',
     'rsrc/css/phui/phui-pinboard-view.css' => '874c22f9',
     'rsrc/css/phui/phui-property-list-view.css' => '2f7199e8',
     'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b',
@@ -762,7 +762,7 @@ return array(
     'phui-info-panel-css' => '27ea50a1',
     'phui-list-view-css' => '43ed2d93',
     'phui-object-box-css' => 'ce92d8ec',
-    'phui-object-item-list-view-css' => '5dfa7e4f',
+    'phui-object-item-list-view-css' => '31d6da4e',
     'phui-pinboard-view-css' => '874c22f9',
     'phui-property-list-view-css' => '2f7199e8',
     'phui-remarkup-preview-css' => '19ad512b',

src/applications/settings/panel/PhabricatorSettingsPanelHomePreferences.php

@@ -127,7 +127,7 @@ final class PhabricatorSettingsPanelHomePreferences
     $list = id(new PHUIObjectItemListView())
       ->setUser($user)
       ->setID($list_id)
-      ->setFlush(true);
+      ->setStackable(true);
 
     Javelin::initBehavior(
       'reorder-applications',

webroot/rsrc/css/phui/phui-object-item-list-view.css

@@ -145,7 +145,7 @@
 }
 
 .phui-object-item-actions .phui-list-item-href:hover {
-  background: #e9e9f9;
+  background: {$hoverblue};
 }
 
 .phui-object-item-actions .phui-list-item-icon {
@@ -195,9 +195,26 @@
 
 .device-desktop .phui-object-list-stackable
   .phui-object-item:hover {
-  background: #e9ecf5;
+  background: {$hoverblue};
 }
 
+.phui-object-box .phui-object-list-stackable {
+  padding: 0;
+}
+
+.phui-object-box .phui-object-list-stackable .phui-object-item {
+  border: none;
+}
+
+.phui-object-box .phui-object-list-stackable .phui-object-item-frame {
+  border-right: none;
+}
+
+.phui-object-box .phui-object-list-stackable:last-child .phui-object-item-frame {
+  border-bottom: none;
+}
+
+
 /* - Subhead -------------------------------------------------------------------
 
   Descriptive Text or Links under the main header, before attributes.
@@ -556,13 +573,26 @@
   border-radius: 3px;
 }
 
+.phui-object-list-stackable .drag-ghost {
+  background: {$hoverblue};
+  margin: 0;
+  border-radius: none;
+  border: none;
+  border-top: 1px solid {$lightgreyborder}
+}
+
 .drag-dragging {
   position: relative;
-  opacity: 0.9;
+  opacity: 0.85;
+}
+
+.phui-object-box .phui-object-list-stackable .drag-dragging
+ .phui-object-item-frame {
+  border-bottom: 1px solid {$lightgreyborder};
 }
 
 .drag-sending {
-  opacity: 0.75;
+  opacity: 0.5;
 }
 
 /* - Plain ---------------------------------------------------------------------