revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Fix two minor breadcrumb issues in Config

Browse source 
Summary:
Fixes T13159. Two issues here:

  - When viewing a particular config setting, there's an extra "Config" crumb.
  - On the page for a config group, the link to the parent group has an extra "/config/" in it.

Test Plan:
  - Viewed a page for a particular setting, no longer saw an extra "Config" crumb.
  - Viewed a page for a setting group, clicked parent crumb, got taken to a real page.

Reviewers: amckinley

Reviewed By: amckinley

Maniphest Tasks: T13159

Differential Revision: https://secure.phabricator.com/D19501
This commit is contained in:
epriestley 2018-06-22 04:57:51 -07:00
parent 8ab8c390b7
commit b1f4a974fe
2 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/config/controller/PhabricatorConfigEditController.php
View file

@ -231,7 +231,6 @@ final class PhabricatorConfigEditController
$box_header[] = $key; $box_header[] = $key;
$crumbs = $this->buildApplicationCrumbs(); $crumbs = $this->buildApplicationCrumbs();
$crumbs->addTextCrumb(pht('Config'), $this->getApplicationURI());
if ($group) { if ($group) {
$crumbs->addTextCrumb($group->getName(), $group_uri); $crumbs->addTextCrumb($group->getName(), $group_uri);
} }

2
src/applications/config/controller/PhabricatorConfigGroupController.php
View file

@ -30,7 +30,7 @@ final class PhabricatorConfigGroupController
$view = $this->buildConfigBoxView($box_header, $list); $view = $this->buildConfigBoxView($box_header, $list);
$crumbs = $this->buildApplicationCrumbs() $crumbs = $this->buildApplicationCrumbs()
->addTextCrumb($group_name, $this->getApplicationURI($group_uri)) ->addTextCrumb($group_name, $group_uri)
->addTextCrumb($options->getName()) ->addTextCrumb($options->getName())
->setBorder(true); ->setBorder(true);