From b21f197a98f23c6523f02de1a43070af853704ec Mon Sep 17 00:00:00 2001 From: epriestley Date: Mon, 30 Sep 2013 17:49:15 -0700 Subject: [PATCH] Fix Diffusion change view header Summary: See D7162. This was like 99% my fault. Just provide a header; the new ones look pretty reasonable. Test Plan: Viewed Diffusion change view, no exception. Reviewers: vrana, chad Reviewed By: chad CC: aran Differential Revision: https://secure.phabricator.com/D7183 --- .../differential/view/DifferentialChangesetListView.php | 7 ++----- .../diffusion/controller/DiffusionChangeController.php | 1 + 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/applications/differential/view/DifferentialChangesetListView.php b/src/applications/differential/view/DifferentialChangesetListView.php index fc8784e2e2..79203f165b 100644 --- a/src/applications/differential/view/DifferentialChangesetListView.php +++ b/src/applications/differential/view/DifferentialChangesetListView.php @@ -194,11 +194,8 @@ final class DifferentialChangesetListView extends AphrontView { )); } - $header = null; - if ($this->getTitle() !== null) { - $header = id(new PHUIHeaderView()) - ->setHeader($this->getTitle()); - } + $header = id(new PHUIHeaderView()) + ->setHeader($this->getTitle()); $content = phutil_tag( 'div', diff --git a/src/applications/diffusion/controller/DiffusionChangeController.php b/src/applications/diffusion/controller/DiffusionChangeController.php index b6fa8599f2..ec5c88231c 100644 --- a/src/applications/diffusion/controller/DiffusionChangeController.php +++ b/src/applications/diffusion/controller/DiffusionChangeController.php @@ -37,6 +37,7 @@ final class DiffusionChangeController extends DiffusionController { ); $changeset_view = new DifferentialChangesetListView(); + $changeset_view->setTitle(pht('Change')); $changeset_view->setChangesets($changesets); $changeset_view->setVisibleChangesets($changesets); $changeset_view->setRenderingReferences(