From b23c85b16915d94cebf37b9cefdc981702ae3f8c Mon Sep 17 00:00:00 2001
From: Chad Little <chad@phacility.com>
Date: Tue, 31 May 2016 12:15:23 -0700
Subject: [PATCH] Add role=dialog to all dialogs

Summary: Seen some complaints about usability here, adding role=dialog to improve when these trigger.

Test Plan: Turn on Voiceover, tab over to log out link, here proper dialog title and text before highlighted submit button.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Differential Revision: https://secure.phabricator.com/D15993
---
 src/view/AphrontDialogView.php | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/view/AphrontDialogView.php b/src/view/AphrontDialogView.php
index 26dee0c398..218839ef6e 100644
--- a/src/view/AphrontDialogView.php
+++ b/src/view/AphrontDialogView.php
@@ -276,6 +276,7 @@ final class AphrontDialogView
     $attributes = array(
       'class'   => implode(' ', $classes),
       'sigil'   => 'jx-dialog',
+      'role'    => 'dialog',
     );
 
     $form_attributes = array(