From b27c2ed6d1e68e94f36db661f856c99d94fc161e Mon Sep 17 00:00:00 2001
From: Austin McKinley <austin@phacility.com>
Date: Fri, 26 May 2017 13:01:28 -0700
Subject: [PATCH] Index Project milestones to accurately reflect milestone
 membership

Summary: Fixes T12505. `PhabricatorProjectsMembershipIndexEngineExtension->materializeProject()` was incorrectly bailing early for milestone objects, which prevented milestone members from being calculated correctly. This was causing problems where (for example) an Owners package owned by a milestone wasn't being satisfied when a member of the milestone approved a revision.

Test Plan: Invoked migration, observed that a user's milestones correctly showed up when searched for. Also observed that accepting a revision on behalf of a milestone now satisfies Owners rules.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T12505

Differential Revision: https://secure.phabricator.com/D18033
---
 .../sql/autopatches/20170526.milestones.php   | 11 ++++++
 ...ProjectsMembershipIndexEngineExtension.php | 35 ++++++++++---------
 2 files changed, 29 insertions(+), 17 deletions(-)
 create mode 100644 resources/sql/autopatches/20170526.milestones.php

diff --git a/resources/sql/autopatches/20170526.milestones.php b/resources/sql/autopatches/20170526.milestones.php
new file mode 100644
index 0000000000..2e30ac4775
--- /dev/null
+++ b/resources/sql/autopatches/20170526.milestones.php
@@ -0,0 +1,11 @@
+<?php
+
+$table = new PhabricatorProject();
+
+foreach (new LiskMigrationIterator($table) as $project) {
+  PhabricatorSearchWorker::queueDocumentForIndexing(
+    $project->getPHID(),
+    array(
+      'force' => true,
+    ));
+}
diff --git a/src/applications/project/engineextension/PhabricatorProjectsMembershipIndexEngineExtension.php b/src/applications/project/engineextension/PhabricatorProjectsMembershipIndexEngineExtension.php
index 567f5b749e..5acfaf913a 100644
--- a/src/applications/project/engineextension/PhabricatorProjectsMembershipIndexEngineExtension.php
+++ b/src/applications/project/engineextension/PhabricatorProjectsMembershipIndexEngineExtension.php
@@ -34,29 +34,30 @@ final class PhabricatorProjectsMembershipIndexEngineExtension
   }
 
   private function materializeProject(PhabricatorProject $project) {
-    if ($project->isMilestone()) {
-      return;
-    }
-
     $material_type = PhabricatorProjectMaterializedMemberEdgeType::EDGECONST;
     $member_type = PhabricatorProjectProjectHasMemberEdgeType::EDGECONST;
 
     $project_phid = $project->getPHID();
 
-    $descendants = id(new PhabricatorProjectQuery())
-      ->setViewer($this->getViewer())
-      ->withAncestorProjectPHIDs(array($project->getPHID()))
-      ->withIsMilestone(false)
-      ->withHasSubprojects(false)
-      ->execute();
-    $descendant_phids = mpull($descendants, 'getPHID');
-
-    if ($descendant_phids) {
-      $source_phids = $descendant_phids;
-      $has_subprojects = true;
-    } else {
-      $source_phids = array($project->getPHID());
+    if ($project->isMilestone()) {
+      $source_phids = array($project->getParentProjectPHID());
       $has_subprojects = false;
+    } else {
+      $descendants = id(new PhabricatorProjectQuery())
+        ->setViewer($this->getViewer())
+        ->withAncestorProjectPHIDs(array($project->getPHID()))
+        ->withIsMilestone(false)
+        ->withHasSubprojects(false)
+        ->execute();
+      $descendant_phids = mpull($descendants, 'getPHID');
+
+      if ($descendant_phids) {
+        $source_phids = $descendant_phids;
+        $has_subprojects = true;
+      } else {
+        $source_phids = array($project->getPHID());
+        $has_subprojects = false;
+      }
     }
 
     $conn_w = $project->establishConnection('w');