From b29e5aa7ca22cb487eeb0725da05c18b46de323b Mon Sep 17 00:00:00 2001
From: Andre Klapper <a9016009@gmx.de>
Date: Wed, 17 Apr 2024 00:40:12 +0200
Subject: [PATCH] Fix PHP 8.1 "strlen(null)" exception for "/bin/search query"
 without parameter

Summary:
`strlen()` was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts `phutil_nonempty_string()` as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

```
ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php:24]
```

Test Plan: Run `../phorge/bin/search query`: Get no `strlen()` error anymore but only expected output `Usage Exception: Specify a query with --query.`

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25589
---
 .../management/PhabricatorSearchManagementQueryWorkflow.php     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php b/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php
index 8e40162a98..c4077e5266 100644
--- a/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php
+++ b/src/applications/search/management/PhabricatorSearchManagementQueryWorkflow.php
@@ -21,7 +21,7 @@ final class PhabricatorSearchManagementQueryWorkflow
   public function execute(PhutilArgumentParser $args) {
     $viewer = $this->getViewer();
     $raw_query = $args->getArg('query');
-    if (!strlen($raw_query)) {
+    if (!phutil_nonempty_string($raw_query)) {
       throw new PhutilArgumentUsageException(
         pht('Specify a query with --query.'));
     }