revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

Use PhabricatorEdgeType strings when rendering transactions

Browse source 
Summary:
Ref T5245. This hooks up the translation/rendering methods added previously.

These are messy, but now extractable/translatable.

Test Plan: Viewed edge transactions and stories, saw correct strings.

Reviewers: chad, btrahan, joshuaspence

Reviewed By: joshuaspence

Subscribers: epriestley

Maniphest Tasks: T5245

Differential Revision: https://secure.phabricator.com/D9841
This commit is contained in:
epriestley 2014-07-17 15:41:54 -07:00
parent 8cbfb49b4e
commit b32313cc85
1 changed files with 45 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

57
src/applications/transactions/storage/PhabricatorApplicationTransaction.php
View file

@ -591,28 +591,25 @@ abstract class PhabricatorApplicationTransaction
$type = $this->getMetadata('edge:type'); $type = $this->getMetadata('edge:type');
$type = head($type); $type = head($type);
$type_obj = PhabricatorEdgeType::getByConstant($type);
if ($add && $rem) { if ($add && $rem) {
$string = PhabricatorEdgeConfig::getEditStringForEdgeType($type); return $type_obj->getTransactionEditString(
return pht(
$string,
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($add), new PhutilNumber(count($add) + count($rem)),
new PhutilNumber(count($add)),
$this->renderHandleList($add), $this->renderHandleList($add),
count($rem), new PhutilNumber(count($rem)),
$this->renderHandleList($rem)); $this->renderHandleList($rem));
} else if ($add) { } else if ($add) {
$string = PhabricatorEdgeConfig::getAddStringForEdgeType($type); return $type_obj->getTransactionAddString(
return pht(
$string,
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($add), new PhutilNumber(count($add)),
$this->renderHandleList($add)); $this->renderHandleList($add));
} else if ($rem) { } else if ($rem) {
$string = PhabricatorEdgeConfig::getRemoveStringForEdgeType($type); return $type_obj->getTransactionRemoveString(
return pht(
$string,
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
count($rem), new PhutilNumber(count($rem)),
$this->renderHandleList($rem)); $this->renderHandleList($rem));
} else { } else {
return pht( return pht(
@ -711,13 +708,43 @@ abstract class PhabricatorApplicationTransaction
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid)); $this->renderHandleLink($object_phid));
case PhabricatorTransactions::TYPE_EDGE: case PhabricatorTransactions::TYPE_EDGE:
$new = ipull($new, 'dst');
$old = ipull($old, 'dst');
$add = array_diff($new, $old);
$rem = array_diff($old, $new);
$type = $this->getMetadata('edge:type'); $type = $this->getMetadata('edge:type');
$type = head($type); $type = head($type);
$string = PhabricatorEdgeConfig::getFeedStringForEdgeType($type);
$type_obj = PhabricatorEdgeType::getByConstant($type);
if ($add && $rem) {
return $type_obj->getFeedEditString(
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
new PhutilNumber(count($add) + count($rem)),
new PhutilNumber(count($add)),
$this->renderHandleList($add),
new PhutilNumber(count($rem)),
$this->renderHandleList($rem));
} else if ($add) {
return $type_obj->getFeedAddString(
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
new PhutilNumber(count($add)),
$this->renderHandleList($add));
} else if ($rem) {
return $type_obj->getFeedRemoveString(
$this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid),
new PhutilNumber(count($rem)),
$this->renderHandleList($rem));
} else {
return pht( return pht(
$string, '%s edited edge metadata for %s.',
$this->renderHandleLink($author_phid), $this->renderHandleLink($author_phid),
$this->renderHandleLink($object_phid)); $this->renderHandleLink($object_phid));
}
case PhabricatorTransactions::TYPE_CUSTOMFIELD: case PhabricatorTransactions::TYPE_CUSTOMFIELD:
$field = $this->getTransactionCustomField(); $field = $this->getTransactionCustomField();
if ($field) { if ($field) {