From b38ad4e45a7e1c0b17859a6d5a13dfffcf50643c Mon Sep 17 00:00:00 2001 From: Chad Little Date: Tue, 20 May 2014 10:53:16 -0700 Subject: [PATCH] Style text boxes and tab panels in dashboards Summary: Adds basic borders, spacing to tab panels and text boxes. Test Plan: Added some of each to my Dashboard. {F157622} Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T5078 Differential Revision: https://secure.phabricator.com/D9216 --- resources/celerity/map.php | 18 +++++++++--------- webroot/rsrc/css/application/feed/feed.css | 10 +++++----- .../layout/phabricator-action-header-view.css | 5 +++-- webroot/rsrc/css/phui/phui-list.css | 8 ++++++++ .../rsrc/css/phui/phui-property-list-view.css | 8 ++++++++ 5 files changed, 33 insertions(+), 16 deletions(-) diff --git a/resources/celerity/map.php b/resources/celerity/map.php index 87e8002019..8c360e269c 100644 --- a/resources/celerity/map.php +++ b/resources/celerity/map.php @@ -7,7 +7,7 @@ return array( 'names' => array( - 'core.pkg.css' => '769b26dc', + 'core.pkg.css' => 'cb82b435', 'core.pkg.js' => 'ab0d6d3d', 'darkconsole.pkg.js' => 'ca8671ce', 'differential.pkg.css' => '382ca868', @@ -66,7 +66,7 @@ return array( 'rsrc/css/application/diffusion/diffusion-icons.css' => '384a0f7d', 'rsrc/css/application/diffusion/diffusion-source.css' => '66fdf661', 'rsrc/css/application/directory/phabricator-jump-nav.css' => 'f0c5e726', - 'rsrc/css/application/feed/feed.css' => '02463b16', + 'rsrc/css/application/feed/feed.css' => 'cdf4718e', 'rsrc/css/application/files/global-drag-and-drop.css' => '697324ad', 'rsrc/css/application/flag/flag.css' => '5337623f', 'rsrc/css/application/harbormaster/harbormaster.css' => 'cec833b7', @@ -114,7 +114,7 @@ return array( 'rsrc/css/font/font-awesome.css' => '73d075c3', 'rsrc/css/font/font-source-sans-pro.css' => '91d53463', 'rsrc/css/font/phui-font-icon-base.css' => '74cfb6a9', - 'rsrc/css/layout/phabricator-action-header-view.css' => '589371fe', + 'rsrc/css/layout/phabricator-action-header-view.css' => '4a011b0c', 'rsrc/css/layout/phabricator-action-list-view.css' => 'dcd9875f', 'rsrc/css/layout/phabricator-crumbs-view.css' => '6a23399c', 'rsrc/css/layout/phabricator-filetree-view.css' => 'a8c86ace', @@ -135,11 +135,11 @@ return array( 'rsrc/css/phui/phui-header-view.css' => '689dbc38', 'rsrc/css/phui/phui-icon.css' => 'ef701b9b', 'rsrc/css/phui/phui-info-panel.css' => '27ea50a1', - 'rsrc/css/phui/phui-list.css' => '65eab261', + 'rsrc/css/phui/phui-list.css' => 'ce29d035', 'rsrc/css/phui/phui-object-box.css' => 'ce92d8ec', 'rsrc/css/phui/phui-object-item-list-view.css' => '64b6b266', 'rsrc/css/phui/phui-pinboard-view.css' => '874c22f9', - 'rsrc/css/phui/phui-property-list-view.css' => 'c7cbe471', + 'rsrc/css/phui/phui-property-list-view.css' => '37a1a369', 'rsrc/css/phui/phui-remarkup-preview.css' => '19ad512b', 'rsrc/css/phui/phui-spacing.css' => '042804d6', 'rsrc/css/phui/phui-status.css' => '2f562399', @@ -689,7 +689,7 @@ return array( 'paste-css' => 'aa1767d1', 'path-typeahead' => 'f7fc67ec', 'people-profile-css' => 'ba7b2762', - 'phabricator-action-header-view-css' => '589371fe', + 'phabricator-action-header-view-css' => '4a011b0c', 'phabricator-action-list-view-css' => 'dcd9875f', 'phabricator-application-launch-view-css' => 'd290ba21', 'phabricator-busy' => '6453c869', @@ -702,7 +702,7 @@ return array( 'phabricator-drag-and-drop-file-upload' => 'ae6abfba', 'phabricator-draggable-list' => '1681c4d4', 'phabricator-fatal-config-template-css' => '25d446d6', - 'phabricator-feed-css' => '02463b16', + 'phabricator-feed-css' => 'cdf4718e', 'phabricator-file-upload' => 'a4ae61bf', 'phabricator-filetree-view-css' => 'a8c86ace', 'phabricator-flag-css' => '5337623f', @@ -767,11 +767,11 @@ return array( 'phui-header-view-css' => '689dbc38', 'phui-icon-view-css' => 'ef701b9b', 'phui-info-panel-css' => '27ea50a1', - 'phui-list-view-css' => '65eab261', + 'phui-list-view-css' => 'ce29d035', 'phui-object-box-css' => 'ce92d8ec', 'phui-object-item-list-view-css' => '64b6b266', 'phui-pinboard-view-css' => '874c22f9', - 'phui-property-list-view-css' => 'c7cbe471', + 'phui-property-list-view-css' => '37a1a369', 'phui-remarkup-preview-css' => '19ad512b', 'phui-spacing-css' => '042804d6', 'phui-status-list-view-css' => '2f562399', diff --git a/webroot/rsrc/css/application/feed/feed.css b/webroot/rsrc/css/application/feed/feed.css index 644eded0b5..8b3e971d18 100644 --- a/webroot/rsrc/css/application/feed/feed.css +++ b/webroot/rsrc/css/application/feed/feed.css @@ -52,14 +52,14 @@ border: none; } -/** Dashboards **/ +/* - Dashboards ------------------------------------------------------------ */ .dashboard-panel .phabricator-feed-frame { background: #fff; margin: 0; - border-left: 1px solid {$lightgreyborder}; - border-right: 1px solid {$lightgreyborder}; - border-bottom: 1px solid {$greyborder}; + border-left: 1px solid {$lightblueborder}; + border-right: 1px solid {$lightblueborder}; + border-bottom: 1px solid {$blueborder}; } .dashboard-panel .phabricator-feed-frame .phabricator-action-header { @@ -75,7 +75,7 @@ .dashboard-panel .phabricator-feed-frame .phui-feed-story { border: none; border-bottom: 1px solid {$thinblueborder}; - margin-bottom: 0; + margin: 0; } .dashboard-panel .phabricator-feed-frame .phui-feed-story-foot { diff --git a/webroot/rsrc/css/layout/phabricator-action-header-view.css b/webroot/rsrc/css/layout/phabricator-action-header-view.css index 7bb2893f6d..81fee37c8b 100644 --- a/webroot/rsrc/css/layout/phabricator-action-header-view.css +++ b/webroot/rsrc/css/layout/phabricator-action-header-view.css @@ -63,10 +63,11 @@ margin-right: 4px; } -/** Dashboards **/ +/* - Dashboards ------------------------------------------------------------ */ .dashboard-panel .phabricator-action-header.gradient-grey-header { - border: 1px solid {$lightgreyborder}; + border: 1px solid {$lightblueborder}; + border-bottom: 1px solid {$thinblueborder}; border-top-left-radius: 5px; border-top-right-radius: 5px; } diff --git a/webroot/rsrc/css/phui/phui-list.css b/webroot/rsrc/css/phui/phui-list.css index a006c417d4..961edf279d 100644 --- a/webroot/rsrc/css/phui/phui-list.css +++ b/webroot/rsrc/css/phui/phui-list.css @@ -166,3 +166,11 @@ .phui-list-item-fail.phui-list-item-selected .phui-list-item-href:hover { background: #f5d3d0; } + +/* - Dashboards ------------------------------------------------------------ */ + +.dashboard-panel .phui-list-view.phui-list-navbar { + border-left: 1px solid {$lightblueborder}; + border-right: 1px solid {$lightblueborder}; + border-bottom: 1px solid {$blueborder}; +} diff --git a/webroot/rsrc/css/phui/phui-property-list-view.css b/webroot/rsrc/css/phui/phui-property-list-view.css index 6efcb2f3fb..5795e975a6 100644 --- a/webroot/rsrc/css/phui/phui-property-list-view.css +++ b/webroot/rsrc/css/phui/phui-property-list-view.css @@ -182,3 +182,11 @@ .device-desktop .phui-property-list-image-content img:hover { background: url('/rsrc/image/checker_dark.png'); } + +/* - Dashboards ------------------------------------------------------------ */ + +.dashboard-panel .phui-property-list-section { + border-left: 1px solid {$lightblueborder}; + border-right: 1px solid {$lightblueborder}; + border-bottom: 1px solid {$blueborder}; +}