Moderize forms on Settings.

Summary: Adds mobile support, new forms.

Test Plan: Clicked on each page after converting. Tested mobile menu

Reviewers: epriestley, btrahan

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D5863

src/__celerity_resource_map__.php

@@ -922,7 +922,7 @@ celerity_register_resource_map(array(
   ),
   'conpherence-message-pane-css' =>
   array(
-    'uri' => '/res/6b49a2d9/rsrc/css/application/conpherence/message-pane.css',
+    'uri' => '/res/52cf7ca3/rsrc/css/application/conpherence/message-pane.css',
     'type' => 'css',
     'requires' =>
     array(

src/applications/settings/controller/PhabricatorSettingsMainController.php

@@ -30,6 +30,8 @@ final class PhabricatorSettingsMainController
       $nav,
       array(
         'title' => $panel->getPanelName(),
+        'device' => true,
+        'dust' => true,
       ));
   }
 
@@ -85,4 +87,9 @@ final class PhabricatorSettingsMainController
     return $nav;
   }
 
+  public function buildApplicationMenu() {
+    $panels = $this->buildPanels();
+    return $this->renderSideNav($panels)->getMenu();
+  }
+
 }

src/applications/settings/panel/PhabricatorSettingsPanelAccount.php

@@ -89,14 +89,13 @@ final class PhabricatorSettingsPanelAccount
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Account Settings'));
+    $header->setHeader(pht('Account Settings'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     return array(
       $notice,
-      $panel,
+      $header,
+      $form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelConduit.php

@@ -78,10 +78,8 @@ final class PhabricatorSettingsPanelConduit
           ->setHeight(AphrontFormTextAreaControl::HEIGHT_SHORT)
           ->setValue($user->getConduitCertificate()));
 
-    $cert = new AphrontPanelView();
+    $header1 = new PhabricatorHeaderView();
-    $cert->setHeader(pht('Arcanist Certificate'));
+    $header1->setHeader(pht('Arcanist Certificate'));
-    $cert->appendChild($cert_form);
-    $cert->setNoBackground();
 
     $regen_instruction = pht('You can regenerate this certificate, which '.
       'will invalidate the old certificate and create a new one.');
@@ -97,15 +95,15 @@ final class PhabricatorSettingsPanelConduit
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Regenerate Certificate')));
 
-    $regen = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $regen->setHeader(pht('Regenerate Certificate'));
+    $header->setHeader(pht('Regenerate Certificate'));
-    $regen->appendChild($regen_form);
-    $regen->setNoBackground();
 
     return array(
       $notice,
-      $cert,
+      $header1,
-      $regen,
+      $cert_form,
+      $header,
+      $regen_form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelConpherencePreferences.php

@@ -56,10 +56,8 @@ final class PhabricatorSettingsPanelConpherencePreferences
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Preferences')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Conpherence Preferences'));
+    $header->setHeader(pht('Conpherence Preferences'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getBool('saved')) {
@@ -71,7 +69,8 @@ final class PhabricatorSettingsPanelConpherencePreferences
 
     return array(
       $error_view,
-      $panel,
+      $header,
+      $form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelDiffPreferences.php

@@ -58,10 +58,8 @@ final class PhabricatorSettingsPanelDiffPreferences
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Preferences')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Diff Preferences'));
+    $header->setHeader(pht('Diff Preferences'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getBool('saved')) {
@@ -73,7 +71,8 @@ final class PhabricatorSettingsPanelDiffPreferences
 
     return array(
       $error_view,
-      $panel,
+      $header,
+      $form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelDisplayPreferences.php

@@ -157,10 +157,8 @@ EXAMPLE;
       id(new AphrontFormSubmitControl())
         ->setValue(pht('Save Preferences')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Display Preferences'));
+    $header->setHeader(pht('Display Preferences'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getStr('saved') === 'true') {
@@ -172,7 +170,8 @@ EXAMPLE;
 
     return array(
       $error_view,
-      $panel,
+      $header,
+      $form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelEmailPreferences.php

@@ -203,16 +203,15 @@ final class PhabricatorSettingsPanelEmailPreferences
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save Preferences')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Email Preferences'));
+    $header->setHeader(pht('Email Preferences'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     return id(new AphrontNullView())
       ->appendChild(
         array(
           $notice,
-          $panel,
+          $header,
+          $form,
         ));
   }
 

src/applications/settings/panel/PhabricatorSettingsPanelLDAP.php

@@ -69,19 +69,22 @@ final class PhabricatorSettingsPanelLDAP
       $forms['Unlink Account'] = $unlink_form;
     }
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('LDAP Account Settings'));
+    $header->setHeader(pht('LDAP Account Settings'));
-    $panel->setNoBackground();
 
+    $formbox = new PHUIBoxView();
     foreach ($forms as $name => $form) {
       if ($name) {
-        $panel->appendChild(hsprintf('<br /><h1>%s</h1><br />', $name));
+        $head = new PhabricatorHeaderView();
+        $head->setHeader($name);
+        $formbox->appendChild($head);
       }
-      $panel->appendChild($form);
+      $formbox->appendChild($form);
     }
 
     return array(
-      $panel,
+      $header,
+      $formbox,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelOAuth.php

@@ -128,7 +128,7 @@ final class PhabricatorSettingsPanelOAuth
       }
 
       if (!$provider->isProviderLinkPermanent()) {
-        $unlink = pht('Unlink %s Account');
+        $unlink = pht('Unlink %s Account', $provider_name);
         $unlink_form = new AphrontFormView();
         $unlink_form
           ->setUser($user)
@@ -208,22 +208,25 @@ final class PhabricatorSettingsPanelOAuth
       $forms['Account Token Information'] = $token_form;
     }
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('%s Account Settings', $provider_name));
+    $header->setHeader(pht('%s Account Settings', $provider_name));
-    $panel->setNoBackground();
 
+    $formbox = new PHUIBoxView();
     foreach ($forms as $name => $form) {
       if ($name) {
-        $panel->appendChild(hsprintf('<br /><h1>%s</h1><br />', $name));
+        $head = new PhabricatorHeaderView();
+        $head->setHeader($name);
+        $formbox->appendChild($head);
       }
-      $panel->appendChild($form);
+      $formbox->appendChild($form);
     }
 
     return id(new AphrontNullView())
       ->appendChild(
         array(
           $notice,
-          $panel,
+          $header,
+          $formbox,
         ));
   }
 

src/applications/settings/panel/PhabricatorSettingsPanelPassword.php

@@ -159,14 +159,13 @@ final class PhabricatorSettingsPanelPassword
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Change Password'));
+    $header->setHeader(pht('Change Password'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     return array(
       $notice,
-      $panel,
+      $header,
+      $form,
     );
   }
 }

src/applications/settings/panel/PhabricatorSettingsPanelProfile.php

@@ -217,14 +217,13 @@ final class PhabricatorSettingsPanelProfile
         ->setValue(pht('Save'))
         ->addCancelButton('/p/'.$user->getUsername().'/'));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Edit Profile Details'));
+    $header->setHeader(pht('Edit Profile Details'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     return array(
       $error_view,
-      $panel,
+      $header,
+      $form,
     );
   }
 

src/applications/settings/panel/PhabricatorSettingsPanelSSHKeys.php

@@ -152,16 +152,15 @@ final class PhabricatorSettingsPanelSSHKeys
           ->addCancelButton($this->getPanelURI())
           ->setValue($save));
 
-    $panel = new AphrontPanelView();
+    $header_title = new PhabricatorHeaderView();
-    $panel->setHeader($header);
+    $header_title->setHeader($header);
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     return id(new AphrontNullView())
       ->appendChild(
         array(
           $error_view,
-          $panel,
+          $header_title,
+          $form,
         ));
   }
 

src/applications/settings/panel/PhabricatorSettingsPanelSearchPreferences.php

@@ -50,10 +50,8 @@ final class PhabricatorSettingsPanelSearchPreferences
         id(new AphrontFormSubmitControl())
           ->setValue(pht('Save')));
 
-    $panel = new AphrontPanelView();
+    $header = new PhabricatorHeaderView();
-    $panel->setHeader(pht('Search Preferences'));
+    $header->setHeader(pht('Search Preferences'));
-    $panel->appendChild($form);
-    $panel->setNoBackground();
 
     $error_view = null;
     if ($request->getStr('saved') === 'true') {
@@ -65,7 +63,8 @@ final class PhabricatorSettingsPanelSearchPreferences
 
     return array(
       $error_view,
-      $panel,
+      $header,
+      $form,
     );
   }
 }