revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2025-01-18 18:51:12 +01:00
Code Issues Releases Wiki Activity

Fix two minor issues

Browse source 
Summary:
Ref T7811. Fixes two minor issues I observed in the cluster:

  - Sometimes APC doesn't give us key names. Not sure exactly what's up here, but we can do a better job with this.
  - The `%` in `25%` actually needs more escaping, since it's interpreted by both `pht()` (immediately) and `console_format()` (later).

Test Plan:
  - First one is just from an error log, not sure how to repro offhand.
  - Ran `bin/phd help start` for the second one.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7814, T7811

Differential Revision: https://secure.phabricator.com/D12395
This commit is contained in:
epriestley 2015-04-13 11:11:18 -07:00
parent d56012ce26
commit b467e58358
2 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/applications/cache/spec/PhabricatorDataCacheSpec.php vendored
View file

@ -83,7 +83,8 @@ final class PhabricatorDataCacheSpec extends PhabricatorCacheSpec {
$cache = $info['cache_list'];
$state = array();
foreach ($cache as $item) {
$key = self::getKeyPattern($item['info']);
$info = idx($item, 'info', '<unknown-key>');
$key = self::getKeyPattern($info);
if (empty($state[$key])) {
$state[$key] = array(
'max' => 0,

2
src/applications/daemon/management/PhabricatorDaemonManagementWorkflow.php
View file

@ -619,7 +619,7 @@ abstract class PhabricatorDaemonManagementWorkflow
'Specify a proportion of machine memory which must be free '.
'before autoscale pools will grow. For example, a value of 0.25 '.
'means that pools will not grow unless the machine has at least '.
'25%% of its RAM free.'),
'25%%%% of its RAM free.'),
);
}