From b4cbea901845087f8903bdcd210303d7e6eace50 Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 29 Aug 2017 12:42:58 -0700 Subject: [PATCH] Make legacy revision statuses from "differential.query" have type "string" again Summary: Ref T2543. The type on these got changed by accident, it should be "string" (crazy nonsense, compatible) not "int" (sensible, not compatible). (New API uses sensible strings like "accepted" only.) Test Plan: Called `differential.query` from web UI, saw `"2"` and similar statuses. Reviewers: chad, jmeador, lvital Reviewed By: jmeador, lvital Maniphest Tasks: T2543 Differential Revision: https://secure.phabricator.com/D18493 --- .../conduit/DifferentialQueryConduitAPIMethod.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php index 0b26db0655..eeef36ee69 100644 --- a/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php +++ b/src/applications/differential/conduit/DifferentialQueryConduitAPIMethod.php @@ -218,7 +218,11 @@ final class DifferentialQueryConduitAPIMethod 'dateCreated' => $revision->getDateCreated(), 'dateModified' => $revision->getDateModified(), 'authorPHID' => $revision->getAuthorPHID(), - 'status' => $revision->getLegacyRevisionStatus(), + + // NOTE: For backward compatibility this is explicitly a string, like + // "2", even though the value of the string is an integer. See PHI14. + 'status' => (string)$revision->getLegacyRevisionStatus(), + 'statusName' => $revision->getStatusDisplayName(), 'properties' => $revision->getProperties(), 'branch' => $diff->getBranch(),