From b4d0de6b96d29ce8e0ac03920ed7439deacd50d8 Mon Sep 17 00:00:00 2001 From: Povilas Balzaravicius Pawka Date: Mon, 23 Mar 2015 06:19:17 -0700 Subject: [PATCH] T7646: Fix buildplan ac on Herald. Summary: Fixes T7646. Test Plan: Repeat steps described in T7646 and expect disabled build plans not displayed. Reviewers: epriestley, #blessed_reviewers Reviewed By: epriestley, #blessed_reviewers Subscribers: Korvin, epriestley Maniphest Tasks: T7646 Differential Revision: https://secure.phabricator.com/D12133 --- .../typeahead/HarbormasterBuildPlanDatasource.php | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php b/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php index ff24094a6b..01b9664a2b 100644 --- a/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php +++ b/src/applications/harbormaster/typeahead/HarbormasterBuildPlanDatasource.php @@ -21,8 +21,14 @@ final class HarbormasterBuildPlanDatasource ->setViewer($viewer) ->execute(); foreach ($plans as $plan) { + $closed = null; + if ($plan->isDisabled()) { + $closed = pht('Disabled'); + } + $results[] = id(new PhabricatorTypeaheadResult()) ->setName($plan->getName()) + ->setClosed($closed) ->setPHID($plan->getPHID()); }