From b5238dc080be2a2c17bde8e68791eafec9807df3 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Wed, 18 Mar 2015 07:08:50 -0700
Subject: [PATCH] Fix bad button construction in Owners

Summary: Fixes T7618. The "button" needs to be a PHUIButtonView later on.

Test Plan: Forced condition, loaded page, saw button instead of fatal.

Reviewers: chad, btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7618

Differential Revision: https://secure.phabricator.com/D12108
---
 .../controller/PhabricatorOwnersDetailController.php  | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/src/applications/owners/controller/PhabricatorOwnersDetailController.php b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
index e261eb848a..1db98f14aa 100644
--- a/src/applications/owners/controller/PhabricatorOwnersDetailController.php
+++ b/src/applications/owners/controller/PhabricatorOwnersDetailController.php
@@ -157,13 +157,10 @@ final class PhabricatorOwnersDetailController
       $commit_views[] = array(
         'view'    => $view,
         'header'  => pht('Commits in this Package that Need Attention'),
-        'button'  => phutil_tag(
-          'a',
-          array(
-            'href'  => $commit_uri->alter('status', 'open'),
-            'class' => 'button grey',
-          ),
-          pht('View All Problem Commits')),
+        'button'  => id(new PHUIButtonView())
+          ->setTag('a')
+          ->setHref($commit_uri->alter('status', 'open'))
+          ->setText(pht('View All Problem Commits')),
       );
     }