mirror of
https://we.phorge.it/source/phorge.git
synced 2024-11-27 01:02:42 +01:00
Stop evaluating Herald rules when writing "someone mentioned this somewhere else." transactions
Summary: Ref T13114. See PHI510. Firing Herald on mentioned objects tends to feel arbitrary and can substantially slow down edits which mention many objects. Test Plan: Mentioned tasks on other tasks; verified that the normal path is hit normally, the new Herald-free path is hit on the mentioned object, and both still work fine and show up in the timeline. Maniphest Tasks: T13114 Differential Revision: https://secure.phabricator.com/D19263
This commit is contained in:
parent
c5b244bfd0
commit
b586ee065a
1 changed files with 5 additions and 0 deletions
|
@ -1120,6 +1120,11 @@ abstract class PhabricatorApplicationTransactionEditor
|
|||
// We are the Herald editor, so stop work here and return the updated
|
||||
// transactions.
|
||||
return $xactions;
|
||||
} else if ($this->getIsInverseEdgeEditor()) {
|
||||
// Do not run Herald if we're just recording that this object was
|
||||
// mentioned elsewhere. This tends to create Herald side effects which
|
||||
// feel arbitrary, and can really slow down edits which mention a large
|
||||
// number of other objects. See T13114.
|
||||
} else if ($this->shouldApplyHeraldRules($object, $xactions)) {
|
||||
// We are not the Herald editor, so try to apply Herald rules.
|
||||
$herald_xactions = $this->applyHeraldRules($object, $xactions);
|
||||
|
|
Loading…
Reference in a new issue