From b596d850ff9d566beedea5e7282150614465e2ef Mon Sep 17 00:00:00 2001 From: epriestley Date: Tue, 1 Dec 2015 13:36:14 -0800 Subject: [PATCH] Fix one more call to `addExtraQuicksandConfig()` Summary: Fixes T9881. This one had Quicksand spelled as "QuickSand" (with capital "S") so it probably didn't get hit by `grep`. Didn't need to do any special magic with the footer, as far as I can tell. Test Plan: Loaded project board view, seemed to work OK (no footer, nav works, title works, mobile menu sane). Reviewers: chad Reviewed By: chad Maniphest Tasks: T9881 Differential Revision: https://secure.phabricator.com/D14626 --- .../PhabricatorProjectBoardViewController.php | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/src/applications/project/controller/PhabricatorProjectBoardViewController.php b/src/applications/project/controller/PhabricatorProjectBoardViewController.php index 12699c8cbc..2d47031942 100644 --- a/src/applications/project/controller/PhabricatorProjectBoardViewController.php +++ b/src/applications/project/controller/PhabricatorProjectBoardViewController.php @@ -282,7 +282,6 @@ final class PhabricatorProjectBoardViewController $this->initBehavior( 'project-boards', $behavior_config); - $this->addExtraQuickSandConfig(array('boardConfig' => $behavior_config)); $this->handles = ManiphestTaskListView::loadTaskHandles($viewer, $tasks); @@ -386,16 +385,21 @@ final class PhabricatorProjectBoardViewController ->addClass('project-board-wrapper'); $nav = $this->buildIconNavView($project); - $nav->appendChild($header_box); - $nav->appendChild($board_box); - return $this->buildApplicationPage( - $nav, - array( - 'title' => pht('%s Board', $project->getName()), - 'showFooter' => false, - 'pageObjects' => array($project->getPHID()), - )); + return $this->newPage() + ->setTitle(pht('%s Board', $project->getName())) + ->setPageObjectPHIDs(array($project->getPHID())) + ->setShowFooter(false) + ->setNavigation($nav) + ->addQuicksandConfig( + array( + 'boardConfig' => $behavior_config, + )) + ->appendChild( + array( + $header_box, + $board_box, + )); } private function buildSortMenu(