From b5ada76ab0925d0dbc788ef8f453c63c93ce066e Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Tue, 2 Aug 2011 07:00:24 -0700
Subject: [PATCH] Explicitly show that "escape" closes dialogs in Phabricator

Summary: See T382. I think bill also asked about this (T308); there's no way to
figure it out right now.
Test Plan:
  - Hit "?", verified the dialog now reveals that escape closes it.
  - Hit escape, dialog vanished.

Reviewed By: jungejason
Reviewers: fzamore, bill, codeblock, jungejason, tuomaspelkonen, aran
CC: aran, jungejason
Differential Revision: 763
---
 .../PhabricatorHelpKeyboardShortcutController.php         | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php b/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
index e3a9a8d4c6..951dfdb518 100644
--- a/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
+++ b/src/applications/help/controller/keyboardshortcut/PhabricatorHelpKeyboardShortcutController.php
@@ -29,6 +29,14 @@ class PhabricatorHelpKeyboardShortcutController
       return new Aphront400Response();
     }
 
+    // There have been at least two users asking for a keyboard shortcut to
+    // close the dialog, so be explicit that escape works since it isn't
+    // terribly discoverable.
+    $keys[] = array(
+      'keys'        => array('esc'),
+      'description' => 'Close any dialog, including this one.',
+    );
+
     $rows = array();
     foreach ($keys as $shortcut) {
       $keystrokes = array();