Convert Harbormaster Build Plans to SearchField

Summary: Ref T8441. Ref T7715. Removes `saveQueryOrder()`.

Test Plan: Used all search features for build plans.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7715, T8441

Differential Revision: https://secure.phabricator.com/D13195

src/applications/harbormaster/query/HarbormasterBuildPlanQuery.php

@@ -28,55 +28,46 @@ final class HarbormasterBuildPlanQuery
     return $this;
   }
 
-  protected function loadPage() {
+  public function newResultObject() {
-    $table = new HarbormasterBuildPlan();
+    return new HarbormasterBuildPlan();
-    $conn_r = $table->establishConnection('r');
-
-    $data = queryfx_all(
-      $conn_r,
-      'SELECT * FROM %T %Q %Q %Q',
-      $table->getTableName(),
-      $this->buildWhereClause($conn_r),
-      $this->buildOrderClause($conn_r),
-      $this->buildLimitClause($conn_r));
-
-    return $table->loadAllFromArray($data);
   }
 
-  protected function buildWhereClause(AphrontDatabaseConnection $conn_r) {
+  protected function loadPage() {
-    $where = array();
+    return $this->loadStandardPage($this->newResultObject());
+  }
 
-    if ($this->ids) {
+  protected function buildWhereClauseParts(AphrontDatabaseConnection $conn) {
+    $where = parent::buildWhereClauseParts($conn);
+
+    if ($this->ids !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'id IN (%Ld)',
         $this->ids);
     }
 
-    if ($this->phids) {
+    if ($this->phids !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'phid IN (%Ls)',
         $this->phids);
     }
 
-    if ($this->statuses) {
+    if ($this->statuses !== null) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'planStatus IN (%Ls)',
         $this->statuses);
     }
 
     if (strlen($this->datasourceQuery)) {
       $where[] = qsprintf(
-        $conn_r,
+        $conn,
         'name LIKE %>',
         $this->datasourceQuery);
     }
 
-    $where[] = $this->buildPagingClause($conn_r);
+    return $where;
-
-    return $this->formatWhereClause($where);
   }
 
   public function getQueryApplicationClass() {

src/applications/harbormaster/query/HarbormasterBuildPlanSearchEngine.php

@@ -11,57 +11,34 @@ final class HarbormasterBuildPlanSearchEngine
     return 'PhabricatorHarbormasterApplication';
   }
 
-  public function buildSavedQueryFromRequest(AphrontRequest $request) {
+  public function newQuery() {
-    $saved = new PhabricatorSavedQuery();
+    return new HarbormasterBuildPlanQuery();
-
-    $saved->setParameter(
-      'status',
-      $this->readListFromRequest($request, 'status'));
-
-    $this->saveQueryOrder($saved, $request);
-
-    return $saved;
   }
 
-  public function buildQueryFromSavedQuery(PhabricatorSavedQuery $saved) {
+  protected function buildCustomSearchFields() {
-    $query = id(new HarbormasterBuildPlanQuery());
+    return array(
-    $this->setQueryOrder($query, $saved);
+      id(new PhabricatorSearchCheckboxesField())
+        ->setLabel(pht('Status'))
+        ->setKey('status')
+        ->setAliases(array('statuses'))
+        ->setOptions(
+          array(
+            HarbormasterBuildPlan::STATUS_ACTIVE => pht('Active'),
+            HarbormasterBuildPlan::STATUS_DISABLED => pht('Disabled'),
+          )),
+    );
+  }
 
-    $status = $saved->getParameter('status', array());
+  public function buildQueryFromParameters(array $map) {
-    if ($status) {
+    $query = $this->newQuery();
-      $query->withStatuses($status);
+
+    if ($map['status']) {
+      $query->withStatuses($map['status']);
     }
 
     return $query;
   }
 
-  public function buildSearchForm(
-    AphrontFormView $form,
-    PhabricatorSavedQuery $saved) {
-
-    $status = $saved->getParameter('status', array());
-
-    $form
-      ->appendChild(
-        id(new AphrontFormCheckboxControl())
-          ->setLabel('Status')
-          ->addCheckbox(
-            'status[]',
-            HarbormasterBuildPlan::STATUS_ACTIVE,
-            pht('Active'),
-            in_array(HarbormasterBuildPlan::STATUS_ACTIVE, $status))
-          ->addCheckbox(
-            'status[]',
-            HarbormasterBuildPlan::STATUS_DISABLED,
-            pht('Disabled'),
-            in_array(HarbormasterBuildPlan::STATUS_DISABLED, $status)));
-
-    $this->appendOrderFieldsToForm(
-      $form,
-      $saved,
-      new HarbormasterBuildPlanQuery());
-  }
-
   protected function getURI($path) {
     return '/harbormaster/plan/'.$path;
   }

src/applications/search/engine/PhabricatorApplicationSearchEngine.php

@@ -891,20 +891,6 @@ abstract class PhabricatorApplicationSearchEngine extends Phobject {
 
 /* -(  Result Ordering  )---------------------------------------------------- */
 
-
-  /**
-   * Save order selection to a @{class:PhabricatorSavedQuery}.
-   */
-  protected function saveQueryOrder(
-    PhabricatorSavedQuery $saved,
-    AphrontRequest $request) {
-
-    $saved->setParameter('order', $request->getStr('order'));
-
-    return $this;
-  }
-
-
   /**
    * Set query ordering from a saved value.
    */