diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php index 4363feac84..fa24e765ae 100644 --- a/src/__phutil_library_map__.php +++ b/src/__phutil_library_map__.php @@ -3159,7 +3159,11 @@ phutil_register_library_map(array( 'DiffusionPathValidateController' => 'DiffusionController', 'DiffusionPushEventViewController' => 'DiffusionPushLogController', 'DiffusionPushLogController' => 'DiffusionController', - 'DiffusionPushLogListController' => 'DiffusionPushLogController', + 'DiffusionPushLogListController' => + array( + 0 => 'DiffusionPushLogController', + 1 => 'PhabricatorApplicationSearchResultsControllerInterface', + ), 'DiffusionQuery' => 'PhabricatorQuery', 'DiffusionRawDiffQuery' => 'DiffusionQuery', 'DiffusionRepositoryController' => 'DiffusionController', diff --git a/src/applications/differential/event/DifferentialActionMenuEventListener.php b/src/applications/differential/event/DifferentialActionMenuEventListener.php index 6f46c44c04..37f736960e 100644 --- a/src/applications/differential/event/DifferentialActionMenuEventListener.php +++ b/src/applications/differential/event/DifferentialActionMenuEventListener.php @@ -34,10 +34,9 @@ final class DifferentialActionMenuEventListener } $person = $event->getValue('object'); - $href = '/differential/?authorPHIDs[]='.$person->getPHID(); + $href = '/differential/?authors='.$person->getUsername(); return id(new PhabricatorActionView()) - ->setRenderAsForm(true) ->setIcon('differential-dark') ->setIconSheet(PHUIIconView::SPRITE_APPS) ->setName(pht('View Revisions')) diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php index 21bfe99f8b..a6b4004b66 100644 --- a/src/applications/home/controller/PhabricatorHomeMainController.php +++ b/src/applications/home/controller/PhabricatorHomeMainController.php @@ -148,8 +148,8 @@ final class PhabricatorHomeMainController 'Nothing appears to be critically broken right now.'); } - $href = sprintf( - '/maniphest/?statuses[]=%s&priorities[]=%s#R', + $href = urisprintf( + '/maniphest/?statuses=%s&priorities=%s#R', implode(',', ManiphestTaskStatus::getOpenStatusConstants()), $unbreak_now); $title = pht('Unbreak Now!'); @@ -196,8 +196,8 @@ final class PhabricatorHomeMainController } $title = pht('Needs Triage'); - $href = sprintf( - '/maniphest/?statuses[]=%s&priorities[]=%s&userProjects[]=%s#R', + $href = urisprintf( + '/maniphest/?statuses=%s&priorities=%s&userProjects=%s#R', implode(',', ManiphestTaskStatus::getOpenStatusConstants()), $needs_triage, $user->getPHID()); diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php index 51b3d57435..a2bb487e24 100644 --- a/src/applications/maniphest/controller/ManiphestReportController.php +++ b/src/applications/maniphest/controller/ManiphestReportController.php @@ -442,7 +442,7 @@ final class ManiphestReportController extends ManiphestController { } } - $base_link = '/maniphest/?allProjects[]='; + $base_link = '/maniphest/?allProjects='; $leftover_name = phutil_tag('em', array(), pht('(No Project)')); $col_header = pht('Project'); $header = pht('Open Tasks by Project and Priority (%s)', $date); diff --git a/src/applications/maniphest/event/ManiphestActionMenuEventListener.php b/src/applications/maniphest/event/ManiphestActionMenuEventListener.php index 43ead47310..0f92bd63fb 100644 --- a/src/applications/maniphest/event/ManiphestActionMenuEventListener.php +++ b/src/applications/maniphest/event/ManiphestActionMenuEventListener.php @@ -44,29 +44,4 @@ final class ManiphestActionMenuEventListener extends PhabricatorEventListener { ->setHref($view_uri); } - private function renderProjectItems(PhutilEvent $event) { - if (!$this->canUseApplication($event->getUser())) { - return null; - } - - $project = $event->getValue('object'); - - $phid = $project->getPHID(); - $view_uri = '/maniphest/?statuses[]=0&allProjects[]='.$phid.'#R'; - $create_uri = '/maniphest/task/create/?projects='.$phid; - - return array( - id(new PhabricatorActionView()) - ->setIcon('maniphest-dark') - ->setIconSheet(PHUIIconView::SPRITE_APPS) - ->setName(pht('View Tasks')) - ->setHref($view_uri), - id(new PhabricatorActionView()) - ->setName(pht("Add Task")) - ->setIcon('create') - ->setHref($create_uri), - ); - } - - } diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php index 9e88e4c87b..0537facaf1 100644 --- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php +++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php @@ -50,7 +50,7 @@ final class ManiphestTaskSearchEngine $saved->setParameter( 'allProjectPHIDs', - $request->getArr('allProjects')); + $this->readPHIDsFromRequest($request, 'allProjects')); $saved->setParameter( 'withNoProject', @@ -58,11 +58,11 @@ final class ManiphestTaskSearchEngine $saved->setParameter( 'anyProjectPHIDs', - $request->getArr('anyProjects')); + $this->readPHIDsFromRequest($request, 'anyProjects')); $saved->setParameter( 'excludeProjectPHIDs', - $request->getArr('excludeProjects')); + $this->readPHIDsFromRequest($request, 'excludeProjects')); $saved->setParameter( 'userProjectPHIDs', diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php index 7a09ca0d77..072756bcd1 100644 --- a/src/applications/project/controller/PhabricatorProjectProfileController.php +++ b/src/applications/project/controller/PhabricatorProjectProfileController.php @@ -148,7 +148,7 @@ final class PhabricatorProjectProfileController $phid = $project->getPHID(); $view_uri = urisprintf( - '/maniphest/?statuses=%s&allProjects[]=%s#R', + '/maniphest/?statuses=%s&allProjects=%s#R', implode(',', ManiphestTaskStatus::getOpenStatusConstants()), $phid); $create_uri = '/maniphest/task/create/?projects='.$phid;