revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 22:10:55 +01:00
Code Issues Releases Wiki Activity

Fix an issue where the Maniphest burnup chart was trying to render a non-View object

Browse source 
Summary:
See PHI1714. This code is incorrectly rendering the chart panel twice, sort of, and passing a non-View object to rendering.

After D21044, this fatals by raising an exception in rendering.

Test Plan: Loaded page, no more exception.

Differential Revision: https://secure.phabricator.com/D21185
This commit is contained in:
epriestley 2020-04-29 04:53:41 -07:00
parent f21f1d8ab9
commit b648a85841
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/maniphest/controller/ManiphestReportController.php
View file

@ -398,15 +398,15 @@ final class ManiphestReportController extends ManiphestController {
->setProjects($projects) ->setProjects($projects)
->buildChartPanel(); ->buildChartPanel();
$chart_panel = $panel->setName(pht('Burnup Rate')); $panel->setName(pht('Burnup Rate'));
$chart_view = id(new PhabricatorDashboardPanelRenderingEngine()) $chart_view = id(new PhabricatorDashboardPanelRenderingEngine())
->setViewer($viewer) ->setViewer($viewer)
->setPanel($chart_panel) ->setPanel($panel)
->setParentPanelPHIDs(array()) ->setParentPanelPHIDs(array())
->renderPanel(); ->renderPanel();
return array($filter, $chart_view, $panel); return array($filter, $chart_view);
} }
private function renderReportFilters(array $tokens, $has_window) { private function renderReportFilters(array $tokens, $has_window) {