revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-23 15:22:41 +01:00
Code Issues Releases Wiki Activity

Fix Phriction feed stories text rendering

Browse source 
Summary: Fixes T3763. All this junk needs some actual fixing at some point, but stop it from fataling.

Test Plan: Used `feed.query` with `view=text`. Before this patch, Phriction stories fataled. Now they render reasonably.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3763

Differential Revision: https://secure.phabricator.com/D6819
This commit is contained in:
epriestley 2013-08-27 09:34:13 -07:00
parent 6f721fb437
commit b64b0f9d23
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/applications/feed/story/PhabricatorFeedStoryPhriction.php
View file

@ -77,8 +77,8 @@ final class PhabricatorFeedStoryPhriction extends PhabricatorFeedStory {
} }
public function renderText() { public function renderText() {
$author_phid = $this->getHandle($this->getAuthorPHID()); $author_handle = $this->getHandle($this->getAuthorPHID());
$author_link = $this->linkTo($author_phid); $author_name = $author_handle->getName();
$document_handle = $this->getHandle($this->getPrimaryObjectPHID()); $document_handle = $this->getHandle($this->getPrimaryObjectPHID());
$document_title = $document_handle->getLinkName(); $document_title = $document_handle->getLinkName();
@ -87,7 +87,7 @@ final class PhabricatorFeedStoryPhriction extends PhabricatorFeedStory {
$action = $this->getValue('action'); $action = $this->getValue('action');
$verb = PhrictionActionConstants::getActionPastTenseVerb($action); $verb = PhrictionActionConstants::getActionPastTenseVerb($action);
$text = "{$author_link} {$verb} the document". $text = "{$author_name} {$verb} the document".
" {$document_title} {$document_uri}"; " {$document_title} {$document_uri}";
return $text; return $text;