revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-23 14:00:56 +01:00
Code Issues Releases Wiki Activity

Remove non-operational shouldHideFromFeed() from ManiphestTaskPointsTransaction

Browse source 
Summary:
See D18018. Ref T12787. This doesn't actually work; we started publishing these stories as a side effect of converting to ModularTransactions, then I fixed the rendering.

This mechanism has very few callsites and I suspect we may want to get rid of it (see T12787) so just keep publishing these stories for now.

Test Plan: Changed the point value of a task, saw a feed story both before and after the patch.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12787

Differential Revision: https://secure.phabricator.com/D18059
This commit is contained in:
epriestley 2017-06-01 08:17:54 -07:00
parent 995c1503e7
commit b69174a4c8
1 changed files with 0 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/maniphest/xaction/ManiphestTaskPointsTransaction.php
View file

@ -17,10 +17,6 @@ final class ManiphestTaskPointsTransaction
$object->setPoints($value); $object->setPoints($value);
} }
public function shouldHideForFeed() {
return true;
}
public function shouldHide() { public function shouldHide() {
if (!ManiphestTaskPoints::getIsEnabled()) { if (!ManiphestTaskPoints::getIsEnabled()) {
return true; return true;