revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-24 06:20:56 +01:00
Code Issues Releases Wiki Activity

"fix" github scope-upgrade flow

Browse source 
Summary:
Can't say I know what I'm doing here, but this fixes an the upgrade-scope flow for landing-to-github.

Without this change, it looks like the submit button makes the browser (Chrome and msie) make the call in the background, instead of hijacking the window.
With it, it works like it should.

Test Plan: try to land with weak token, click "Refresh..", see GitHub button.

Reviewers: #blessed_reviewers, epriestley

Reviewed By: #blessed_reviewers, epriestley

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9407
This commit is contained in:
Aviv Eyal 2014-06-07 12:05:30 -07:00 committed by epriestley
parent 6c48f11a07
commit b6bc8b8c0f
1 changed files with 1 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/applications/differential/landing/DifferentialLandingToGitHub.php
View file

@ -172,6 +172,7 @@ final class DifferentialLandingToGitHub
'stronger GitHub token.')) 'stronger GitHub token.'))
->setSubmitURI($refresh_token_uri) ->setSubmitURI($refresh_token_uri)
->addCancelButton('/D'.$revision->getId()) ->addCancelButton('/D'.$revision->getId())
->setDisableWorkflowOnSubmit(true)
->addSubmitButton(pht('Refresh Account Link')); ->addSubmitButton(pht('Refresh Account Link'));
} }
} }