revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-09-20 09:18:48 +02:00
Code Issues Releases Wiki Activity

Prevent audit email from sending as the wrong user

Browse source 
Summary: We may overwrite $comment as a side effect of iteration.

Test Plan: Made some audit comments as different users.

Reviewers: vrana, btrahan

Reviewed By: vrana

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2050
This commit is contained in:
epriestley 2012-03-29 13:23:45 -07:00
parent 813329c0a5
commit b6e0ca5ac6
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/applications/audit/editor/comment/PhabricatorAuditCommentEditor.php
View file

@ -301,8 +301,8 @@ final class PhabricatorAuditCommentEditor {
}
$email_cc = array();
foreach ($other_comments as $comment) {
$email_cc[] = $comment->getActorPHID();
foreach ($other_comments as $other_comment) {
$email_cc[] = $other_comment->getActorPHID();
}
$phids = array_merge($email_to, $email_cc);