From b72b6eb18ff6da43b72fc81ff48c91d13f229040 Mon Sep 17 00:00:00 2001 From: Chad Little Date: Wed, 22 Jul 2015 13:26:13 -0700 Subject: [PATCH] Allow XHPAST to be viewed public Summary: Ref T4830. Not sure this //should// be public (consume resources?) Test Plan: View logged out. Reviewers: btrahan, epriestley Reviewed By: epriestley Subscribers: epriestley, Korvin Maniphest Tasks: T4830 Differential Revision: https://secure.phabricator.com/D13674 --- .../controller/PhabricatorXHPASTViewFrameController.php | 4 ++++ .../controller/PhabricatorXHPASTViewFramesetController.php | 4 ++++ .../controller/PhabricatorXHPASTViewPanelController.php | 4 ++++ .../phpast/controller/PhabricatorXHPASTViewTreeController.php | 4 ++++ 4 files changed, 16 insertions(+) diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php index 8d6e690205..560d4203a0 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFrameController.php @@ -5,6 +5,10 @@ final class PhabricatorXHPASTViewFrameController private $id; + public function shouldAllowPublic() { + return true; + } + public function willProcessRequest(array $data) { $this->id = $data['id']; } diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php index 2ca3b17e96..a21bb30b68 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewFramesetController.php @@ -5,6 +5,10 @@ final class PhabricatorXHPASTViewFramesetController private $id; + public function shouldAllowPublic() { + return true; + } + public function willProcessRequest(array $data) { $this->id = $data['id']; } diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php index ab68948af3..8f824dc03f 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewPanelController.php @@ -6,6 +6,10 @@ abstract class PhabricatorXHPASTViewPanelController private $id; private $storageTree; + public function shouldAllowPublic() { + return true; + } + public function willProcessRequest(array $data) { $this->id = $data['id']; $this->storageTree = id(new PhabricatorXHPASTViewParseTree()) diff --git a/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php b/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php index b332784e92..7da285f121 100644 --- a/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php +++ b/src/applications/phpast/controller/PhabricatorXHPASTViewTreeController.php @@ -3,6 +3,10 @@ final class PhabricatorXHPASTViewTreeController extends PhabricatorXHPASTViewPanelController { + public function shouldAllowPublic() { + return true; + } + public function processRequest() { $storage = $this->getStorageTree(); $input = $storage->getInput();