From b7e0f97d336c0faae06b9ed46acc5ea45c0436a2 Mon Sep 17 00:00:00 2001 From: vrana Date: Thu, 2 Feb 2012 18:39:15 -0800 Subject: [PATCH] Use GET form in Owners search Summary: The form doesn't perform any action, only displays data. URL wouldn't exceed its maximum length. Bookmarking results can be useful. Linking from other pages can be even more useful. Also browsing through history is more fluent. Test Plan: Search by path. Search by owner. Reviewers: epriestley Reviewed By: epriestley CC: aran, epriestley Differential Revision: https://secure.phabricator.com/D1559 --- .../owners/controller/list/PhabricatorOwnersListController.php | 1 + 1 file changed, 1 insertion(+) diff --git a/src/applications/owners/controller/list/PhabricatorOwnersListController.php b/src/applications/owners/controller/list/PhabricatorOwnersListController.php index f49ba67bf3..b3619937db 100644 --- a/src/applications/owners/controller/list/PhabricatorOwnersListController.php +++ b/src/applications/owners/controller/list/PhabricatorOwnersListController.php @@ -135,6 +135,7 @@ class PhabricatorOwnersListController extends PhabricatorOwnersController { $form = id(new AphrontFormView()) ->setUser($user) ->setAction('/owners/view/search/') + ->setMethod('GET') ->appendChild( id(new AphrontFormTextControl()) ->setName('name')