mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
Conpherence - hide file transactions
Summary: added support for when showHide is true AND set showHide to true for Files. Test Plan: loaded a conpherence and saw no more "updated files" transacations Reviewers: chad, epriestley Reviewed By: chad CC: aran, Korvin Maniphest Tasks: T2399, T2411 Differential Revision: https://secure.phabricator.com/D4649
This commit is contained in:
parent
cf346d3c81
commit
b7f7b8aff0
2 changed files with 5 additions and 1 deletions
|
@ -112,6 +112,9 @@ final class ConpherenceViewController extends
|
||||||
|
|
||||||
$transactions = $conpherence->getTransactions();
|
$transactions = $conpherence->getTransactions();
|
||||||
foreach ($transactions as $transaction) {
|
foreach ($transactions as $transaction) {
|
||||||
|
if ($transaction->shouldHide()) {
|
||||||
|
continue;
|
||||||
|
}
|
||||||
$rendered_transactions[] = id(new ConpherenceTransactionView())
|
$rendered_transactions[] = id(new ConpherenceTransactionView())
|
||||||
->setUser($user)
|
->setUser($user)
|
||||||
->setConpherenceTransaction($transaction)
|
->setConpherenceTransaction($transaction)
|
||||||
|
|
|
@ -29,8 +29,9 @@ final class ConpherenceTransaction extends PhabricatorApplicationTransaction {
|
||||||
return ($old === null);
|
return ($old === null);
|
||||||
case ConpherenceTransactionType::TYPE_TITLE:
|
case ConpherenceTransactionType::TYPE_TITLE:
|
||||||
case ConpherenceTransactionType::TYPE_PICTURE:
|
case ConpherenceTransactionType::TYPE_PICTURE:
|
||||||
case ConpherenceTransactionType::TYPE_FILES:
|
|
||||||
return false;
|
return false;
|
||||||
|
case ConpherenceTransactionType::TYPE_FILES:
|
||||||
|
return true;
|
||||||
}
|
}
|
||||||
|
|
||||||
return parent::shouldHide();
|
return parent::shouldHide();
|
||||||
|
|
Loading…
Reference in a new issue