From b8154cb5e91a4e753bfccf91a3ea69a2a65d4022 Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 25 Sep 2013 14:37:34 -0700 Subject: [PATCH] Clean up Maniphest email "to" Summary: We currently try to send Maniphest email "To" the owner and actor, but for unassigned tasks there is no owner. Just filter the PHIDs in the parent, since it's reasonable for subclasses to be liberal about construction here. Test Plan: Commented on an unassigned task, got an email without a bogus "To". Reviewers: btrahan, asherkin Reviewed By: btrahan CC: aran Differential Revision: https://secure.phabricator.com/D7129 --- .../editor/PhabricatorApplicationTransactionEditor.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php index 3306377898..c3b4bcb0fc 100644 --- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php +++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php @@ -1205,8 +1205,8 @@ abstract class PhabricatorApplicationTransactionEditor PhabricatorLiskDAO $object, array $xactions) { - $email_to = array_unique($this->getMailTo($object)); - $email_cc = array_unique($this->getMailCC($object)); + $email_to = array_filter(array_unique($this->getMailTo($object))); + $email_cc = array_filter(array_unique($this->getMailCC($object))); $phids = array_merge($email_to, $email_cc); $handles = id(new PhabricatorHandleQuery())