revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 00:32:42 +01:00
Code Issues Releases Wiki Activity

Remove "HarbormasterBuildTransaction::TYPE_CREATE"

Browse source 
Summary: Ref T13072. No callers currently generate these transactions, and they probably never have. Remove them.

Test Plan: Grepped for "HarbormasterBuildTransaction::TYPE_CREATE" and "self::TYPE_CREATE" in the class, found no hits.

Subscribers: PHID-OPKG-gm6ozazyms6q6i22gyam

Maniphest Tasks: T13072

Differential Revision: https://secure.phabricator.com/D21688
This commit is contained in:
epriestley 2021-07-15 11:07:21 -07:00
parent bf83fffca1
commit b84c02959a
2 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/harbormaster/editor/HarbormasterBuildTransactionEditor.php
View file

@ -14,7 +14,6 @@ final class HarbormasterBuildTransactionEditor
public function getTransactionTypes() { public function getTransactionTypes() {
$types = parent::getTransactionTypes(); $types = parent::getTransactionTypes();
$types[] = HarbormasterBuildTransaction::TYPE_CREATE;
$types[] = HarbormasterBuildTransaction::TYPE_COMMAND; $types[] = HarbormasterBuildTransaction::TYPE_COMMAND;
return $types; return $types;
@ -25,7 +24,6 @@ final class HarbormasterBuildTransactionEditor
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case HarbormasterBuildTransaction::TYPE_CREATE:
case HarbormasterBuildTransaction::TYPE_COMMAND: case HarbormasterBuildTransaction::TYPE_COMMAND:
return null; return null;
} }
@ -38,8 +36,6 @@ final class HarbormasterBuildTransactionEditor
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case HarbormasterBuildTransaction::TYPE_CREATE:
return true;
case HarbormasterBuildTransaction::TYPE_COMMAND: case HarbormasterBuildTransaction::TYPE_COMMAND:
return $xaction->getNewValue(); return $xaction->getNewValue();
} }
@ -52,8 +48,6 @@ final class HarbormasterBuildTransactionEditor
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case HarbormasterBuildTransaction::TYPE_CREATE:
return;
case HarbormasterBuildTransaction::TYPE_COMMAND: case HarbormasterBuildTransaction::TYPE_COMMAND:
return $this->executeBuildCommand($object, $xaction); return $this->executeBuildCommand($object, $xaction);
} }
@ -98,7 +92,6 @@ final class HarbormasterBuildTransactionEditor
PhabricatorApplicationTransaction $xaction) { PhabricatorApplicationTransaction $xaction) {
switch ($xaction->getTransactionType()) { switch ($xaction->getTransactionType()) {
case HarbormasterBuildTransaction::TYPE_CREATE:
case HarbormasterBuildTransaction::TYPE_COMMAND: case HarbormasterBuildTransaction::TYPE_COMMAND:
return; return;
} }

9
src/applications/harbormaster/storage/HarbormasterBuildTransaction.php
View file

@ -3,7 +3,6 @@
final class HarbormasterBuildTransaction final class HarbormasterBuildTransaction
extends PhabricatorApplicationTransaction { extends PhabricatorApplicationTransaction {
const TYPE_CREATE = 'harbormaster:build:create';
const TYPE_COMMAND = 'harbormaster:build:command'; const TYPE_COMMAND = 'harbormaster:build:command';
public function getApplicationName() { public function getApplicationName() {
@ -21,10 +20,6 @@ final class HarbormasterBuildTransaction
$new = $this->getNewValue(); $new = $this->getNewValue();
switch ($this->getTransactionType()) { switch ($this->getTransactionType()) {
case self::TYPE_CREATE:
return pht(
'%s created this build.',
$this->renderHandleLink($author_phid));
case self::TYPE_COMMAND: case self::TYPE_COMMAND:
switch ($new) { switch ($new) {
case HarbormasterBuildCommand::COMMAND_RESTART: case HarbormasterBuildCommand::COMMAND_RESTART:
@ -55,8 +50,6 @@ final class HarbormasterBuildTransaction
$new = $this->getNewValue(); $new = $this->getNewValue();
switch ($this->getTransactionType()) { switch ($this->getTransactionType()) {
case self::TYPE_CREATE:
return 'fa-plus';
case self::TYPE_COMMAND: case self::TYPE_COMMAND:
switch ($new) { switch ($new) {
case HarbormasterBuildCommand::COMMAND_RESTART: case HarbormasterBuildCommand::COMMAND_RESTART:
@ -80,8 +73,6 @@ final class HarbormasterBuildTransaction
$new = $this->getNewValue(); $new = $this->getNewValue();
switch ($this->getTransactionType()) { switch ($this->getTransactionType()) {
case self::TYPE_CREATE:
return 'green';
case self::TYPE_COMMAND: case self::TYPE_COMMAND:
switch ($new) { switch ($new) {
case HarbormasterBuildCommand::COMMAND_PAUSE: case HarbormasterBuildCommand::COMMAND_PAUSE: