From b89e6c0fa91a5b5472122c33bb5cbc6e7d2b1fcf Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 1 May 2020 12:51:34 -0700 Subject: [PATCH] Add "idea://" to the upstream editor whitelist Summary: This supports the IntelliJ IDEA editor. Test Plan: - Looked at the editor settings panel, saw "idea://". - Set my editor pattern to "idea://a?b". - (Did not actually install IntelliJ IDEA.) Differential Revision: https://secure.phabricator.com/D21206 --- .../config/option/PhabricatorSecurityConfigOptions.php | 3 +++ .../settings/panel/PhabricatorExternalEditorSettingsPanel.php | 1 + 2 files changed, 4 insertions(+) diff --git a/src/applications/config/option/PhabricatorSecurityConfigOptions.php b/src/applications/config/option/PhabricatorSecurityConfigOptions.php index b71de40773..3438d3bd67 100644 --- a/src/applications/config/option/PhabricatorSecurityConfigOptions.php +++ b/src/applications/config/option/PhabricatorSecurityConfigOptions.php @@ -213,6 +213,9 @@ EOTEXT // This handler is for Visual Studio Code. 'vscode' => true, + + // This is for IntelliJ IDEA. + 'idea' => true, )) ->setSummary(pht('Whitelists editor protocols for "Open in Editor".')) ->setDescription( diff --git a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php index d9e8736954..c331d3d762 100644 --- a/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php +++ b/src/applications/settings/panel/PhabricatorExternalEditorSettingsPanel.php @@ -105,6 +105,7 @@ final class PhabricatorExternalEditorSettingsPanel 'emacs' => pht('Emacs'), 'vscode' => pht('Visual Studio Code'), 'editor' => pht('Generic Editor'), + 'idea' => pht('IntelliJ IDEA'), ); $default_label = phutil_tag('em', array(), pht('Supported Protocol'));