revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-26 16:52:41 +01:00
Code Issues Releases Wiki Activity

Clarify language when Autoclose is disabled for a repository

Browse source 
Summary: Fixes T12051, adds additional language.

Test Plan:
Disable Autoclose in Actions, see updated language under Branches.

{F5147291}

Reviewers: epriestley

Reviewed By: epriestley

Spies: Korvin

Maniphest Tasks: T12051

Differential Revision: https://secure.phabricator.com/D18482
This commit is contained in:
Chad Little 2017-08-28 11:41:48 -07:00
parent 37843127e9
commit b8b701faf7
1 changed files with 11 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/applications/diffusion/management/DiffusionRepositoryBranchesManagementPanel.php
View file

@ -86,8 +86,11 @@ final class DiffusionRepositoryBranchesManagementPanel
$repository->getHumanReadableDetail('close-commits-filter', array()), $repository->getHumanReadableDetail('close-commits-filter', array()),
phutil_tag('em', array(), pht('Autoclose On All Branches'))); phutil_tag('em', array(), pht('Autoclose On All Branches')));
$autoclose_disabled = false;
if ($repository->getDetail('disable-autoclose')) { if ($repository->getDetail('disable-autoclose')) {
$autoclose_only = phutil_tag('em', array(), pht('Disabled')); $autoclose_disabled = true;
$autoclose_only =
phutil_tag('em', array(), pht('Autoclose has been disabled'));
} }
$view->addProperty(pht('Autoclose Only'), $autoclose_only); $view->addProperty(pht('Autoclose Only'), $autoclose_only);
@ -133,12 +136,18 @@ final class DiffusionRepositoryBranchesManagementPanel
$status = pht('Open'); $status = pht('Open');
} }
if ($autoclose_disabled) {
$autoclose_status = pht('Disabled (Repository)');
} else {
$autoclose_status = pht('Off');
}
$rows[] = array( $rows[] = array(
$icon, $icon,
$branch_name, $branch_name,
$status, $status,
$tracking ? pht('Tracking') : pht('Off'), $tracking ? pht('Tracking') : pht('Off'),
$autoclosing ? pht('Autoclose On') : pht('Off'), $autoclosing ? pht('Autoclose On') : $autoclose_status,
); );
} }
$branch_table = new AphrontTableView($rows); $branch_table = new AphrontTableView($rows);