Change closed tasks to view as disabled

Summary: This cleans up the UI of closed tasks in Maniphest task view, removes the Foot and sets view to disabled.

Test Plan: Searched for all tasks

Reviewers: epriestley

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7712

src/__celerity_resource_map__.php

@@ -3937,7 +3937,7 @@ celerity_register_resource_map(array(
   ),
   'phui-object-item-list-view-css' =>
   array(
-    'uri' => '/res/c3a0ea74/rsrc/css/phui/phui-object-item-list-view.css',
+    'uri' => '/res/d29162b3/rsrc/css/phui/phui-object-item-list-view.css',
     'type' => 'css',
     'requires' =>
     array(
@@ -4343,7 +4343,7 @@ celerity_register_resource_map(array(
 ), array(
   'packages' =>
   array(
-    'ea1ae5d8' =>
+    '4eb25d41' =>
     array(
       'name' => 'core.pkg.css',
       'symbols' =>
@@ -4392,7 +4392,7 @@ celerity_register_resource_map(array(
         41 => 'phabricator-tag-view-css',
         42 => 'phui-list-view-css',
       ),
-      'uri' => '/res/pkg/ea1ae5d8/core.pkg.css',
+      'uri' => '/res/pkg/4eb25d41/core.pkg.css',
       'type' => 'css',
     ),
     '2c1dba03' =>
@@ -4584,15 +4584,15 @@ celerity_register_resource_map(array(
   ),
   'reverse' =>
   array(
-    'aphront-dialog-view-css' => 'ea1ae5d8',
-    'aphront-error-view-css' => 'ea1ae5d8',
-    'aphront-list-filter-view-css' => 'ea1ae5d8',
-    'aphront-pager-view-css' => 'ea1ae5d8',
-    'aphront-panel-view-css' => 'ea1ae5d8',
-    'aphront-table-view-css' => 'ea1ae5d8',
-    'aphront-tokenizer-control-css' => 'ea1ae5d8',
-    'aphront-tooltip-css' => 'ea1ae5d8',
-    'aphront-typeahead-control-css' => 'ea1ae5d8',
+    'aphront-dialog-view-css' => '4eb25d41',
+    'aphront-error-view-css' => '4eb25d41',
+    'aphront-list-filter-view-css' => '4eb25d41',
+    'aphront-pager-view-css' => '4eb25d41',
+    'aphront-panel-view-css' => '4eb25d41',
+    'aphront-table-view-css' => '4eb25d41',
+    'aphront-tokenizer-control-css' => '4eb25d41',
+    'aphront-tooltip-css' => '4eb25d41',
+    'aphront-typeahead-control-css' => '4eb25d41',
     'differential-changeset-view-css' => '67248472',
     'differential-core-view-css' => '67248472',
     'differential-inline-comment-editor' => '92f459f0',
@@ -4606,7 +4606,7 @@ celerity_register_resource_map(array(
     'differential-table-of-contents-css' => '67248472',
     'diffusion-commit-view-css' => '7aa115b4',
     'diffusion-icons-css' => '7aa115b4',
-    'global-drag-and-drop-css' => 'ea1ae5d8',
+    'global-drag-and-drop-css' => '4eb25d41',
     'inline-comment-summary-css' => '67248472',
     'javelin-aphlict' => '2c1dba03',
     'javelin-behavior' => '3e3be199',
@@ -4681,56 +4681,56 @@ celerity_register_resource_map(array(
     'javelin-util' => '3e3be199',
     'javelin-vector' => '3e3be199',
     'javelin-workflow' => '3e3be199',
-    'lightbox-attachment-css' => 'ea1ae5d8',
+    'lightbox-attachment-css' => '4eb25d41',
     'maniphest-task-summary-css' => '49898640',
-    'phabricator-action-list-view-css' => 'ea1ae5d8',
-    'phabricator-application-launch-view-css' => 'ea1ae5d8',
+    'phabricator-action-list-view-css' => '4eb25d41',
+    'phabricator-application-launch-view-css' => '4eb25d41',
     'phabricator-busy' => '2c1dba03',
     'phabricator-content-source-view-css' => '67248472',
-    'phabricator-core-css' => 'ea1ae5d8',
-    'phabricator-crumbs-view-css' => 'ea1ae5d8',
+    'phabricator-core-css' => '4eb25d41',
+    'phabricator-crumbs-view-css' => '4eb25d41',
     'phabricator-drag-and-drop-file-upload' => '92f459f0',
     'phabricator-dropdown-menu' => '2c1dba03',
     'phabricator-file-upload' => '2c1dba03',
-    'phabricator-filetree-view-css' => 'ea1ae5d8',
-    'phabricator-flag-css' => 'ea1ae5d8',
+    'phabricator-filetree-view-css' => '4eb25d41',
+    'phabricator-flag-css' => '4eb25d41',
     'phabricator-hovercard' => '2c1dba03',
-    'phabricator-jump-nav' => 'ea1ae5d8',
+    'phabricator-jump-nav' => '4eb25d41',
     'phabricator-keyboard-shortcut' => '2c1dba03',
     'phabricator-keyboard-shortcut-manager' => '2c1dba03',
-    'phabricator-main-menu-view' => 'ea1ae5d8',
+    'phabricator-main-menu-view' => '4eb25d41',
     'phabricator-menu-item' => '2c1dba03',
-    'phabricator-nav-view-css' => 'ea1ae5d8',
+    'phabricator-nav-view-css' => '4eb25d41',
     'phabricator-notification' => '2c1dba03',
-    'phabricator-notification-css' => 'ea1ae5d8',
-    'phabricator-notification-menu-css' => 'ea1ae5d8',
+    'phabricator-notification-css' => '4eb25d41',
+    'phabricator-notification-menu-css' => '4eb25d41',
     'phabricator-object-selector-css' => '67248472',
     'phabricator-phtize' => '2c1dba03',
     'phabricator-prefab' => '2c1dba03',
     'phabricator-project-tag-css' => '49898640',
-    'phabricator-remarkup-css' => 'ea1ae5d8',
+    'phabricator-remarkup-css' => '4eb25d41',
     'phabricator-shaped-request' => '92f459f0',
-    'phabricator-side-menu-view-css' => 'ea1ae5d8',
-    'phabricator-standard-page-view' => 'ea1ae5d8',
-    'phabricator-tag-view-css' => 'ea1ae5d8',
+    'phabricator-side-menu-view-css' => '4eb25d41',
+    'phabricator-standard-page-view' => '4eb25d41',
+    'phabricator-tag-view-css' => '4eb25d41',
     'phabricator-textareautils' => '2c1dba03',
     'phabricator-tooltip' => '2c1dba03',
-    'phabricator-transaction-view-css' => 'ea1ae5d8',
-    'phabricator-zindex-css' => 'ea1ae5d8',
-    'phui-button-css' => 'ea1ae5d8',
-    'phui-form-css' => 'ea1ae5d8',
-    'phui-form-view-css' => 'ea1ae5d8',
-    'phui-header-view-css' => 'ea1ae5d8',
-    'phui-icon-view-css' => 'ea1ae5d8',
-    'phui-list-view-css' => 'ea1ae5d8',
-    'phui-object-item-list-view-css' => 'ea1ae5d8',
-    'phui-property-list-view-css' => 'ea1ae5d8',
-    'phui-spacing-css' => 'ea1ae5d8',
-    'sprite-apps-large-css' => 'ea1ae5d8',
-    'sprite-gradient-css' => 'ea1ae5d8',
-    'sprite-icons-css' => 'ea1ae5d8',
-    'sprite-menu-css' => 'ea1ae5d8',
-    'sprite-status-css' => 'ea1ae5d8',
-    'syntax-highlighting-css' => 'ea1ae5d8',
+    'phabricator-transaction-view-css' => '4eb25d41',
+    'phabricator-zindex-css' => '4eb25d41',
+    'phui-button-css' => '4eb25d41',
+    'phui-form-css' => '4eb25d41',
+    'phui-form-view-css' => '4eb25d41',
+    'phui-header-view-css' => '4eb25d41',
+    'phui-icon-view-css' => '4eb25d41',
+    'phui-list-view-css' => '4eb25d41',
+    'phui-object-item-list-view-css' => '4eb25d41',
+    'phui-property-list-view-css' => '4eb25d41',
+    'phui-spacing-css' => '4eb25d41',
+    'sprite-apps-large-css' => '4eb25d41',
+    'sprite-gradient-css' => '4eb25d41',
+    'sprite-icons-css' => '4eb25d41',
+    'sprite-menu-css' => '4eb25d41',
+    'sprite-status-css' => '4eb25d41',
+    'syntax-highlighting-css' => '4eb25d41',
   ),
 ));

src/applications/maniphest/view/ManiphestTaskListView.php

@@ -59,11 +59,7 @@ final class ManiphestTaskListView extends ManiphestView {
 
       $status = $task->getStatus();
       if ($status != ManiphestTaskStatus::STATUS_OPEN) {
-        $item->addFootIcon(
-          ($status == ManiphestTaskStatus::STATUS_CLOSED_RESOLVED)
-            ? 'enable-white'
-            : 'delete-white',
-          idx($status_map, $status, 'Unknown'));
+        $item->setDisabled(true);
       }
 
       $item->setBarColor(idx($color_map, $task->getPriority(), 'grey'));

src/applications/uiexample/examples/PHUIObjectItemListExample.php

@@ -130,6 +130,7 @@ final class PHUIObjectItemListExample extends PhabricatorUIExample {
       id(new PHUIObjectItemView())
         ->setHeader(pht('House of Cards'))
         ->setBarColor('yellow')
+        ->setDisabled(true)
         ->addByline(pht('Owner: %s', $owner)));
 
     $author = phutil_tag('a', array('href' => '#'), pht('agoat'));

webroot/rsrc/css/phui/phui-object-item-list-view.css

@@ -370,12 +370,18 @@
   border-left-color: #d7d7d7;
 }
 
+.phui-object-item-disabled .phui-object-item-link,
+.phui-object-item-disabled .phui-object-item-link a {
+  color: {$lightgreytext};
+}
+
 .phui-object-item-disabled .phui-object-item-frame {
   border-color: #d7d7d7;
 }
 
 .phui-object-item-disabled .phui-object-item-objname {
   color: {$greytext};
+  text-decoration: line-through;
 }