revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 14:52:41 +01:00
Code Issues Releases Wiki Activity

Changed \$callsign to \$argv[1] on commit_hook.php since is undefined causing an error when trying to report an error.

Browse source 
Summary:
Phabricator was going to give me an error message via commit_hook.php, unfortunately said error wasn't being set since
\$callsign was undefined. So, just changed \$callsign to \$argv[1] and now I get the appropriate commit.

Test Plan:
1. Add commit_hook.php to an SVN pre-commit.
2. Set the SVN to be hosted off of Phabricator.
3. Attempt to commit to commit to SVN repository.
Expected: Error message saying that the repository isn't hosted on Phabricator
Results: Error message saying undefined function.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7920
This commit is contained in:
John Mullanaphy 2014-01-09 10:35:31 -08:00 committed by epriestley
parent 3c5756adf9
commit b960c8114b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
scripts/repository/commit_hook.php
View file

@ -17,12 +17,12 @@ $repository = id(new PhabricatorRepositoryQuery())
->executeOne(); ->executeOne();
if (!$repository) { if (!$repository) {
throw new Exception(pht('No such repository "%s"!', $callsign)); throw new Exception(pht('No such repository "%s"!', $argv[1]));
} }
if (!$repository->isHosted()) { if (!$repository->isHosted()) {
// This should be redundant, but double check just in case. // This should be redundant, but double check just in case.
throw new Exception(pht('Repository "%s" is not hosted!', $callsign)); throw new Exception(pht('Repository "%s" is not hosted!', $argv[1]));
} }
$engine->setRepository($repository); $engine->setRepository($repository);