From b9931fa34027a38a8940393493f27af8793e7456 Mon Sep 17 00:00:00 2001 From: epriestley Date: Fri, 23 Mar 2012 11:08:10 -0700 Subject: [PATCH] Fix reuse of $link in report controller Summary: $link gets reused later in the function, use a different variable name to avoid broken nonsense. Test Plan: Clicked users/projects links. Reviewers: btrahan Reviewed By: btrahan CC: aran, epriestley Maniphest Tasks: T1038 Differential Revision: https://secure.phabricator.com/D2003 --- .../controller/report/ManiphestReportController.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/applications/maniphest/controller/report/ManiphestReportController.php b/src/applications/maniphest/controller/report/ManiphestReportController.php index 683253ca0f..e226a5184f 100644 --- a/src/applications/maniphest/controller/report/ManiphestReportController.php +++ b/src/applications/maniphest/controller/report/ManiphestReportController.php @@ -433,7 +433,7 @@ final class ManiphestReportController extends ManiphestController { '(Up For Grabs)'); $col_header = 'User'; $header = 'Open Tasks by User and Priority ('.$date.')'; - $link = '/maniphest/?users='; + $base_link = '/maniphest/?users='; break; case 'project': $result = array(); @@ -470,7 +470,7 @@ final class ManiphestReportController extends ManiphestController { '(No Project)'); $col_header = 'Project'; $header = 'Open Tasks by Project and Priority ('.$date.')'; - $link = '/maniphest/view/all/?projects='; + $base_link = '/maniphest/view/all/?projects='; break; } @@ -498,7 +498,7 @@ final class ManiphestReportController extends ManiphestController { $name = phutil_render_tag( 'a', array( - 'href' => $link.$handle->getPHID(), + 'href' => $base_link.$handle->getPHID(), ), phutil_escape_html($handle->getName())); $closed = idx($result_closed, $handle->getPHID(), array());