Add renderHTMLView

Summary:
  - Implement AphrontView->renderHTMLView(), which works like AphrontView->renderSingleView() but always return PhutilSafeHTML.

Test Plan: Action list view no longer as broken.

Reviewers: vrana

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D4642

src/view/AphrontView.php

@@ -50,6 +50,22 @@ abstract class AphrontView extends Phobject {
     }
   }
 
+  final protected function renderHTMLView($child) {
+    if ($child instanceof AphrontView) {
+      return phutil_safe_html($child->render());
+    } else if ($child instanceof PhutilSafeHTML) {
+      return $child;
+    } else if (is_array($child)) {
+      $out = array();
+      foreach ($child as $element) {
+        $out[] = $this->renderHTMLView($element);
+      }
+      return phutil_safe_html(implode('', $out));
+    } else {
+      return phutil_safe_html(phutil_escape_html($child));
+    }
+  }
+
   abstract public function render();
 
 }

src/view/layout/PhabricatorActionListView.php

@@ -36,12 +36,13 @@ final class PhabricatorActionListView extends AphrontView {
     }
 
     require_celerity_resource('phabricator-action-list-view-css');
-    return phutil_render_tag(
+
+    return phutil_tag(
       'ul',
       array(
         'class' => 'phabricator-action-list-view',
       ),
-      $this->renderSingleView($actions));
+      $this->renderHTMLView($actions));
   }
 
 

src/view/layout/PhabricatorHeaderView.php

@@ -39,12 +39,12 @@ final class PhabricatorHeaderView extends AphrontView {
     }
 
     if ($this->tags) {
-      $header[] = phutil_render_tag(
+      $header[] = phutil_tag(
         'span',
         array(
           'class' => 'phabricator-header-tags',
         ),
-        self::renderSingleView($this->tags));
+        $this->renderHTMLView($this->tags));
     }
 
     return phutil_tag(