revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-10 08:52:39 +01:00
Code Issues Releases Wiki Activity

Prevent Differential changeset HTML anchors from colliding with comment anchors

Browse source 
Summary:
Fixes T12970. This is easier than I expected, and appears to occur in only one place.

This prevents a change from ever generating with an anchor like `#12345678`, which is ambiguous because it may be a comment anchor.

Test Plan: Viewed a revision, saw new `change-xxxyyyzzz` anchors, clicked one, got jumped to the right place.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T12970

Differential Revision: https://secure.phabricator.com/D18465
This commit is contained in:
epriestley 2017-08-24 13:38:52 -07:00
parent bc0963d54b
commit ba1925b155
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/differential/storage/DifferentialChangeset.php
View file

@ -170,7 +170,7 @@ final class DifferentialChangeset extends DifferentialDAO
} }
public function getAnchorName() { public function getAnchorName() {
return substr(md5($this->getFilename()), 0, 8); return 'change-'.PhabricatorHash::digestForIndex($this->getFilename());
} }
public function getAbsoluteRepositoryPath( public function getAbsoluteRepositoryPath(