revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-19 12:00:55 +01:00
Code Issues Releases Wiki Activity

Diffusion - fix commits not importing fully

Browse source 
Summary: Fixes T6336. Turns out that the function to update the import status updates that database and doesn't update the object. If the object doesn't get the pertinent update AND there's a herald rule that runs, then the object is later re-saved without ever getting the update flag.

Test Plan: logic in the ole sandbox and going to push it to prod and run re-parse on impacted commits

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley, chad

Maniphest Tasks: T6336

Differential Revision: https://secure.phabricator.com/D10723
This commit is contained in:
Bob Trahan 2014-10-17 09:41:27 -07:00
parent e6d946661d
commit ba2963ecb3
2 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/applications/audit/editor/PhabricatorAuditEditor.php
View file

@ -22,7 +22,12 @@ final class PhabricatorAuditEditor
if (isset($this->auditReasonMap[$phid])) { if (isset($this->auditReasonMap[$phid])) {
return $this->auditReasonMap[$phid]; return $this->auditReasonMap[$phid];
} }
return array('Added by '.$this->getActor()->getUsername().'.'); if ($this->getIsHeraldEditor()) {
$name = 'herald';
} else {
$name = $this->getActor()->getUsername();
}
return array('Added by '.$name.'.');
} }
public function setRawPatch($patch) { public function setRawPatch($patch) {

1
src/applications/repository/storage/PhabricatorRepositoryCommit.php
View file

@ -59,6 +59,7 @@ final class PhabricatorRepositoryCommit
$this->getTableName(), $this->getTableName(),
$flag, $flag,
$this->getID()); $this->getID());
$this->setImportStatus($this->getImportStatus() | $flag);
return $this; return $this;
} }