revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-11-22 06:42:42 +01:00
Code Issues Releases Wiki Activity

PHP 8 and Diviner Technical Documentation

Browse source 
Summary:
This also fixes the field Personal Settings > Display Preferences > Monospaced Font, when empty.

Close T15621

Test Plan: Generate diviner stuff, navigate to the "Technical Documentation" section (In php 8.1+)

Reviewers: O1 Blessed Committers, mturdus, valerio.bozzolan

Reviewed By: O1 Blessed Committers, mturdus, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15621

Differential Revision: https://we.phorge.it/D25412
This commit is contained in:
Aviv Eyal 2023-08-18 12:28:03 -07:00
parent 3cc5ee6a33
commit ba4b8cb1ae
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/applications/diviner/storage/DivinerLiveSymbol.php
View file

@ -172,7 +172,7 @@ final class DivinerLiveSymbol extends DivinerDAO
public function getTitle() {
$title = parent::getTitle();
if (!strlen($title)) {
if (!phutil_nonempty_string($title)) {
$title = $this->getName();
}

2
src/applications/settings/setting/PhabricatorMonospacedFontSetting.php
View file

@ -25,7 +25,7 @@ final class PhabricatorMonospacedFontSetting
}
public function validateTransactionValue($value) {
if (!strlen($value)) {
if (!phutil_nonempty_string($value)) {
return;
}