mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 05:50:55 +01:00
PHP 8 and Diviner Technical Documentation
Summary: This also fixes the field Personal Settings > Display Preferences > Monospaced Font, when empty. Close T15621 Test Plan: Generate diviner stuff, navigate to the "Technical Documentation" section (In php 8.1+) Reviewers: O1 Blessed Committers, mturdus, valerio.bozzolan Reviewed By: O1 Blessed Committers, mturdus, valerio.bozzolan Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno Maniphest Tasks: T15621 Differential Revision: https://we.phorge.it/D25412
This commit is contained in:
parent
3cc5ee6a33
commit
ba4b8cb1ae
2 changed files with 2 additions and 2 deletions
|
@ -172,7 +172,7 @@ final class DivinerLiveSymbol extends DivinerDAO
|
|||
public function getTitle() {
|
||||
$title = parent::getTitle();
|
||||
|
||||
if (!strlen($title)) {
|
||||
if (!phutil_nonempty_string($title)) {
|
||||
$title = $this->getName();
|
||||
}
|
||||
|
||||
|
|
|
@ -25,7 +25,7 @@ final class PhabricatorMonospacedFontSetting
|
|||
}
|
||||
|
||||
public function validateTransactionValue($value) {
|
||||
if (!strlen($value)) {
|
||||
if (!phutil_nonempty_string($value)) {
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in a new issue