Ship "Repositories" create button to new Diffusion workflow

Summary: Ref T2231. Get rid of the old create controller and make the button go to the new stuff instead. This will eventually get cleaned up more, but I don't have a clear plan for Arcanist Projects yet.

Test Plan: Clicked button, hit new workflow.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2231

Differential Revision: https://secure.phabricator.com/D7414

src/applications/repository/application/PhabricatorApplicationRepositories.php

@@ -29,8 +29,6 @@ final class PhabricatorApplicationRepositories extends PhabricatorApplication {
     return array(
       '/repository/' => array(
         ''                     => 'PhabricatorRepositoryListController',
-        'create/'              => 'PhabricatorRepositoryCreateController',
-        'delete/(?P<id>[1-9]\d*)/'  => 'PhabricatorRepositoryDeleteController',
         'project/edit/(?P<id>[1-9]\d*)/' =>
           'PhabricatorRepositoryArcanistProjectEditController',
         'project/delete/(?P<id>[1-9]\d*)/' =>

src/applications/repository/controller/PhabricatorRepositoryCreateController.php

@@ -1,119 +0,0 @@
-<?php
-
-final class PhabricatorRepositoryCreateController
-  extends PhabricatorRepositoryController {
-
-  public function processRequest() {
-
-
-    $request = $this->getRequest();
-    $user = $request->getUser();
-
-    $e_name = true;
-    $e_callsign = true;
-
-    $repository = new PhabricatorRepository();
-
-    $type_map = PhabricatorRepositoryType::getAllRepositoryTypes();
-    $errors = array();
-
-    if ($request->isFormPost()) {
-
-      $repository->setName($request->getStr('name'));
-      $repository->setCallsign($request->getStr('callsign'));
-      $repository->setVersionControlSystem($request->getStr('type'));
-
-      if (!strlen($repository->getName())) {
-        $e_name = 'Required';
-        $errors[] = 'Repository name is required.';
-      } else {
-        $e_name = null;
-      }
-
-      if (!strlen($repository->getCallsign())) {
-        $e_callsign = 'Required';
-        $errors[] = 'Callsign is required.';
-      } else if (!preg_match('/^[A-Z]+$/', $repository->getCallsign())) {
-        $e_callsign = 'Invalid';
-        $errors[] = 'Callsign must be ALL UPPERCASE LETTERS.';
-      } else {
-        $e_callsign = null;
-      }
-
-      if (empty($type_map[$repository->getVersionControlSystem()])) {
-        $errors[] = 'Invalid version control system.';
-      }
-
-      if (!$errors) {
-        try {
-          $repository->save();
-
-          return id(new AphrontRedirectResponse())
-            ->setURI('/repository/edit/'.$repository->getID().'/');
-
-        } catch (AphrontQueryDuplicateKeyException $ex) {
-          $e_callsign = 'Duplicate';
-          $errors[] = 'Callsign must be unique. Another repository already '.
-                      'uses that callsign.';
-        }
-      }
-    }
-
-    $error_view = null;
-    if ($errors) {
-      $error_view = new AphrontErrorView();
-      $error_view->setErrors($errors);
-      $error_view->setTitle('Form Errors');
-    }
-
-    $form = new AphrontFormView();
-    $form
-      ->setUser($user)
-      ->setAction('/repository/create/')
-      ->appendChild(
-        id(new AphrontFormTextControl())
-          ->setLabel('Name')
-          ->setName('name')
-          ->setValue($repository->getName())
-          ->setError($e_name)
-          ->setCaption('Human-readable repository name.'))
-      ->appendChild(hsprintf(
-        '<p class="aphront-form-instructions">Select a "Callsign" &mdash; a '.
-        'short, uppercase string to identify revisions in this repository. If '.
-        'you choose "EX", revisions in this repository will be identified '.
-        'with the prefix "rEX".</p>'))
-      ->appendChild(
-        id(new AphrontFormTextControl())
-          ->setLabel('Callsign')
-          ->setName('callsign')
-          ->setValue($repository->getCallsign())
-          ->setError($e_callsign)
-          ->setCaption(
-            'Short, UPPERCASE identifier. Once set, it can not be changed.'))
-      ->appendChild(
-        id(new AphrontFormSelectControl())
-          ->setLabel('Type')
-          ->setName('type')
-          ->setOptions($type_map)
-          ->setValue($repository->getVersionControlSystem()))
-      ->appendChild(
-        id(new AphrontFormSubmitControl())
-          ->setValue('Create Repository')
-          ->addCancelButton('/repository/'));
-
-    $form_box = id(new PHUIObjectBoxView())
-      ->setHeaderText(pht('Create Repository'))
-      ->setFormError($error_view)
-      ->setForm($form);
-
-    return $this->buildApplicationPage(
-      array(
-        $form_box,
-      ),
-      array(
-        'title' => pht('Create Repository'),
-        'device' => true,
-      ));
-  }
-
-}

src/applications/repository/controller/PhabricatorRepositoryListController.php

@@ -74,7 +74,7 @@ final class PhabricatorRepositoryListController
     $panel = new AphrontPanelView();
     $panel->setHeader('Repositories');
     if ($is_admin) {
-      $panel->setCreateButton('Create New Repository', '/repository/create/');
+      $panel->setCreateButton('Create New Repository', '/diffusion/create/');
     }
     $panel->appendChild($table);
     $panel->setNoBackground();