Seperate repository home and browse view in tab menu

Summary:
The tab menu in a repository can be a bit confusing. The first tab will be rendered active for two distinctive states:

- the home view in the currently selected branch
- the browse view in the currently selected branch

This diff will give the home view a dedicated extra tab. When switching the branches, we won't switch between home and browse view like it is done now.

And I have changed the crumb text for the browse view to "Code" to match it up with the tab name.

Additionally the readme is now the first content on the home view.

Fixes T15728

Test Plan: Browse in your favorite repos and feel an UX elevation.

Reviewers: O1 Blessed Committers, avivey, valerio.bozzolan

Reviewed By: O1 Blessed Committers, avivey, valerio.bozzolan

Subscribers: avivey, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15728

Differential Revision: https://we.phorge.it/D25538

src/applications/diffusion/controller/DiffusionController.php

@@ -211,7 +211,7 @@ abstract class DiffusionController extends PhabricatorController {
         $view_name = pht('History');
         break;
       case 'browse':
-        $view_name = pht('Browse');
+        $view_name = pht('Code');
         break;
       case 'lint':
         $view_name = pht('Lint');
@@ -502,6 +502,18 @@ abstract class DiffusionController extends PhabricatorController {
 
     $view = new PHUIListView();
 
+    $view->addMenuItem(
+      id(new PHUIListItemView())
+        ->setKey('home')
+        ->setName(pht('Home'))
+        ->setIcon('fa-home')
+        ->setHref($drequest->generateURI(
+          array(
+            'action' => 'branch',
+            'path' => '',
+          )))
+        ->setSelected($key == 'home'));
+
     $view->addMenuItem(
       id(new PHUIListItemView())
         ->setKey('code')

src/applications/diffusion/controller/DiffusionRepositoryController.php

@@ -109,7 +109,7 @@ final class DiffusionRepositoryController extends DiffusionController {
         ->setErrors(array($empty_message));
     }
 
-    $tabs = $this->buildTabsView('code');
+    $tabs = $this->buildTabsView('home');
 
     $clone_uri = $drequest->generateURI(
       array(
@@ -243,16 +243,16 @@ final class DiffusionRepositoryController extends DiffusionController {
       $readme = null;
     }
 
+    if ($readme) {
+      $content[] = $readme;
+    }
+
     $content[] = $this->buildBrowseTable(
       $browse_results,
       $browse_paths,
       $browse_exception,
       $browse_pager);
 
-    if ($readme) {
-      $content[] = $readme;
-    }
-
     try {
       $branch_button = $this->buildBranchList($drequest);
       $this->branchButton = $branch_button;
@@ -396,7 +396,7 @@ final class DiffusionRepositoryController extends DiffusionController {
     foreach ($branches as $branch) {
       $branch_uri = $drequest->generateURI(
         array(
-          'action' => 'browse',
+          'action' => 'branch',
           'branch' => $branch->getShortname(),
         ));
       $actions->addAction(