revi-archive/phorge-phorge
1
0
Fork 0
mirror of https://we.phorge.it/source/phorge.git synced 2024-12-21 21:10:56 +01:00
Code Issues Releases Wiki Activity

Change password_hash() algorithm from CRYPT_BLOWFISH to PASSWORD_BCRYPT.

Browse source 
Summary:
PHP 5.5 specifies constant PASSWORD_BCRYPT should be used in password_hash()
instead of CRYPT_BLOWFISH. Using CRYPT_BLOWFISH is not supported in either PHP
or HHVM. This constant breaks Username / Password authentication.

Test Plan:
Login using Username/Password with bcrypt hash. Before applying the patch,
No matter what password entered, it will always fail authentication. After this
patch, user should be able to login with bcrypt hash.

Reviewers: btrahan, epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D8808
This commit is contained in:
Wenyu Zhang 2014-04-18 13:38:36 -07:00 committed by epriestley
parent 35df988036
commit ba956711a5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/infrastructure/util/password/PhabricatorBcryptPasswordHasher.php
View file

@ -38,7 +38,7 @@ final class PhabricatorBcryptPasswordHasher
'cost' => $this->getBcryptCost(), 'cost' => $this->getBcryptCost(),
); );
$raw_hash = password_hash($raw_input, CRYPT_BLOWFISH, $options); $raw_hash = password_hash($raw_input, PASSWORD_BCRYPT, $options);
return new PhutilOpaqueEnvelope($raw_hash); return new PhutilOpaqueEnvelope($raw_hash);
} }