Add rulePHID to HeraldEffect

Summary: Ref T4195. Herald rules gained PHIDs only recently, propagate them to HeraldEffect to make some of the hook stuff eaiser.

Test Plan: iiam

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4195

Differential Revision: https://secure.phabricator.com/D7781

src/applications/herald/engine/HeraldEffect.php

@@ -2,14 +2,15 @@
 
 final class HeraldEffect {
 
-  protected $objectPHID;
+  private $objectPHID;
-  protected $action;
+  private $action;
-  protected $target;
+  private $target;
 
-  protected $ruleID;
+  private $ruleID;
-  protected $effector;
+  private $rulePHID;
+  private $effector;
 
-  protected $reason;
+  private $reason;
 
   public function setObjectPHID($object_phid) {
     $this->objectPHID = $object_phid;
@@ -47,6 +48,15 @@ final class HeraldEffect {
     return $this->ruleID;
   }
 
+  public function setRulePHID($rule_phid) {
+    $this->rulePHID = $rule_phid;
+    return $this;
+  }
+
+  public function getRulePHID() {
+    return $this->rulePHID;
+  }
+
   public function setEffector($effector) {
     $this->effector = $effector;
     return $this;

src/applications/herald/engine/HeraldEngine.php

@@ -359,6 +359,7 @@ final class HeraldEngine {
       $effect->setTarget($action->getTarget());
 
       $effect->setRuleID($rule->getID());
+      $effect->setRulePHID($rule->getPHID());
 
       $name = $rule->getName();
       $id   = $rule->getID();