mirror of
https://we.phorge.it/source/phorge.git
synced 2024-12-23 22:10:55 +01:00
Respect repository identities when selecting author vs auditor actions
Summary: Depends on D20580. Fixes T13311. When we choose which actions to show a user, we can either show them "auditor" actions (like "raise concern") or "author" actions (like "request verification"). Currently, we don't show "author" actions if you're the author of the commit via an identity mapping, but we should. Use identity mappings where they exist. (Because I've implemented `getEffectiveAuthorPHID()` in a way that requires `$data` be attached, it's possible this will make something throw a "DataNotAttached" exception, but: probably it won't?; and that's easy to fix if it happens.) Test Plan: See D20580. As `@alice`, viewed the commit in the UI. - Before: got auditor actions presented to me. - After: got author actions. Reviewers: amckinley Reviewed By: amckinley Maniphest Tasks: T13311 Differential Revision: https://secure.phabricator.com/D20581
This commit is contained in:
parent
4450c90881
commit
bab35f28e4
1 changed files with 1 additions and 1 deletions
|
@ -63,7 +63,7 @@ abstract class DiffusionCommitActionTransaction
|
|||
return false;
|
||||
}
|
||||
|
||||
return ($viewer->getPHID() === $commit->getAuthorPHID());
|
||||
return ($viewer->getPHID() === $commit->getEffectiveAuthorPHID());
|
||||
}
|
||||
|
||||
public function newEditField(
|
||||
|
|
Loading…
Reference in a new issue