From bad576db9275a335efcd6263d325e1344e62ce28 Mon Sep 17 00:00:00 2001 From: Ricky Elrod Date: Sun, 16 Dec 2012 12:01:06 -0800 Subject: [PATCH] Fix an exception in Ponder comment saving. Summary: Add a `setViewer()` so that PHID loading doesn't throw. Also remove a period from a button because none of the others have one. Test Plan: Saved a comment successfully. Reviewers: epriestley Reviewed By: epriestley CC: aran, Korvin Differential Revision: https://secure.phabricator.com/D4202 --- .../ponder/controller/PonderCommentSaveController.php | 1 + src/applications/ponder/view/PonderAddAnswerView.php | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/applications/ponder/controller/PonderCommentSaveController.php b/src/applications/ponder/controller/PonderCommentSaveController.php index 151ec30c17..399c9580fc 100644 --- a/src/applications/ponder/controller/PonderCommentSaveController.php +++ b/src/applications/ponder/controller/PonderCommentSaveController.php @@ -18,6 +18,7 @@ final class PonderCommentSaveController extends PonderController { $target = $request->getStr('target'); $objects = id(new PhabricatorObjectHandleData(array($target))) + ->setViewer($user) ->loadHandles(); if (!$objects) { return new Aphront404Response(); diff --git a/src/applications/ponder/view/PonderAddAnswerView.php b/src/applications/ponder/view/PonderAddAnswerView.php index d60f0abc06..073a2b0e96 100644 --- a/src/applications/ponder/view/PonderAddAnswerView.php +++ b/src/applications/ponder/view/PonderAddAnswerView.php @@ -48,7 +48,7 @@ final class PonderAddAnswerView extends AphrontView { ->setUser($this->user)) ->appendChild( id(new AphrontFormSubmitControl()) - ->setValue($is_serious ? 'Submit' : 'Make it so.')); + ->setValue($is_serious ? 'Submit' : 'Make it so')); $preview = '
'.