From bb0d13345d6a7b0c9741ae28a4db2d0d8ffc30e8 Mon Sep 17 00:00:00 2001
From: epriestley <git@epriestley.com>
Date: Sat, 15 Aug 2015 10:54:27 -0700
Subject: [PATCH] Remove unused revisionID and whitespace properties from diff
 TOC view

Summary: Ref T2183. These properties are not used and not useful.

Test Plan: Grepped for callsites and uses. Loaded revisions.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T2183

Differential Revision: https://secure.phabricator.com/D13906
---
 .../DifferentialRevisionViewController.php           |  2 --
 .../view/DifferentialDiffTableOfContentsView.php     | 12 ------------
 2 files changed, 14 deletions(-)

diff --git a/src/applications/differential/controller/DifferentialRevisionViewController.php b/src/applications/differential/controller/DifferentialRevisionViewController.php
index 085e888fe5..aa8daa76d6 100644
--- a/src/applications/differential/controller/DifferentialRevisionViewController.php
+++ b/src/applications/differential/controller/DifferentialRevisionViewController.php
@@ -359,8 +359,6 @@ final class DifferentialRevisionViewController extends DifferentialController {
     }
     $toc_view->setDiff($target);
     $toc_view->setUser($user);
-    $toc_view->setRevisionID($revision->getID());
-    $toc_view->setWhitespace($whitespace);
 
     $comment_form = null;
     if (!$viewer_is_anonymous) {
diff --git a/src/applications/differential/view/DifferentialDiffTableOfContentsView.php b/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
index 26161096fe..3bbe588ed0 100644
--- a/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
+++ b/src/applications/differential/view/DifferentialDiffTableOfContentsView.php
@@ -8,8 +8,6 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
   private $repository;
   private $diff;
   private $renderURI = '/differential/changeset/';
-  private $revisionID;
-  private $whitespace;
   private $coverageMap;
 
   public function setChangesets($changesets) {
@@ -42,16 +40,6 @@ final class DifferentialDiffTableOfContentsView extends AphrontView {
     return $this;
   }
 
-  public function setRevisionID($revision_id) {
-    $this->revisionID = $revision_id;
-    return $this;
-  }
-
-  public function setWhitespace($whitespace) {
-    $this->whitespace = $whitespace;
-    return $this;
-  }
-
   public function render() {
 
     $this->requireResource('differential-core-view-css');