From bb8bc4ff546ad49eeecdcb2d3223f526ff7d574e Mon Sep 17 00:00:00 2001 From: epriestley Date: Wed, 9 Feb 2011 09:17:21 -0800 Subject: [PATCH] Make commit message parsing at least sort of work. Summary: Test Plan: Reviewers: CC: --- .../parser/commitmessage/DifferentialCommitMessage.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php b/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php index dcc62b47b7..152ef02d0e 100755 --- a/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php +++ b/src/applications/differential/parser/commitmessage/DifferentialCommitMessage.php @@ -215,8 +215,11 @@ class DifferentialCommitMessage { if ($need_users) { $users = id(new PhabricatorUser())->loadAllWhere( - 'username IN (%Ls) OR email IN (%Ls)', + '(username IN (%Ls)) OR (email IN (%Ls))', + $need_users, $need_users); + $users = mpull($users, 'getPHID', 'getUsername') + + mpull($users, 'getPHID', 'getEmail'); } else { $users = array(); } @@ -225,6 +228,7 @@ class DifferentialCommitMessage { $mail = id(new PhabricatorMetaMTAMailingList())->loadAllWhere( 'email in (%Ls)', $need_mail); + $mail = mpull($mail, 'getPHID', 'getEmail'); } else { $mail = array(); }